Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1901833002: [Cleanup] No wchar_t for Cocoa. (Closed)

Created:
4 years, 8 months ago by groby-ooo-7-16
Modified:
4 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] No wchar_t for Cocoa. Move logging messages from wchar_t to good old comfy char. BUG=110650 Committed: https://crrev.com/00b48cd3abfb4e57474110ccc221354647030bbb Cr-Commit-Position: refs/heads/master@{#388058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
groby-ooo-7-16
PTAL
4 years, 8 months ago (2016-04-18 21:25:29 UTC) #4
Nico
lgtm
4 years, 8 months ago (2016-04-18 21:51:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901833002/1
4 years, 8 months ago (2016-04-18 22:32:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 22:38:55 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 22:40:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00b48cd3abfb4e57474110ccc221354647030bbb
Cr-Commit-Position: refs/heads/master@{#388058}

Powered by Google App Engine
This is Rietveld 408576698