Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901823002: fiddle_build_test depends on skia_mesa (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fiddle_build_test depends on skia_mesa Builds on Build-Ubuntu-GCC-x86_64-Release-Mesa-Trybot Shouldn't break anything else. Committed: https://skia.googlesource.com/skia/+/63677f4c2c8f7e60686f1c293c4a9643232f1067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gyp/tools.gyp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901823002/1
4 years, 8 months ago (2016-04-18 19:22:35 UTC) #4
hal.canary
PTAL
4 years, 8 months ago (2016-04-18 19:29:31 UTC) #8
jcgregorio
lgtm
4 years, 8 months ago (2016-04-18 19:29:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901823002/1
4 years, 8 months ago (2016-04-18 19:41:11 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 19:42:08 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/63677f4c2c8f7e60686f1c293c4a9643232f1067

Powered by Google App Engine
This is Rietveld 408576698