Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: src/compiler/verifier.cc

Issue 1901803002: [turbofan] Remove phase ordering problem in JSToNumber lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 742 matching lines...) Expand 10 before | Expand all | Expand 10 after
753 case IrOpcode::kObjectIsString: 753 case IrOpcode::kObjectIsString:
754 case IrOpcode::kObjectIsUndetectable: 754 case IrOpcode::kObjectIsUndetectable:
755 CheckValueInputIs(node, 0, Type::Any()); 755 CheckValueInputIs(node, 0, Type::Any());
756 CheckUpperIs(node, Type::Boolean()); 756 CheckUpperIs(node, Type::Boolean());
757 break; 757 break;
758 case IrOpcode::kAllocate: 758 case IrOpcode::kAllocate:
759 CheckValueInputIs(node, 0, Type::PlainNumber()); 759 CheckValueInputIs(node, 0, Type::PlainNumber());
760 CheckUpperIs(node, Type::TaggedPointer()); 760 CheckUpperIs(node, Type::TaggedPointer());
761 break; 761 break;
762 762
763 case IrOpcode::kChangeSmiToInt32: {
764 // Signed32 /\ Tagged -> Signed32 /\ UntaggedInt32
765 // TODO(neis): Activate once ChangeRepresentation works in typer.
766 // Type* from = Type::Intersect(Type::Signed32(), Type::Tagged());
767 // Type* to = Type::Intersect(Type::Signed32(), Type::UntaggedInt32());
768 // CheckValueInputIs(node, 0, from));
769 // CheckUpperIs(node, to));
770 break;
771 }
763 case IrOpcode::kChangeTaggedToInt32: { 772 case IrOpcode::kChangeTaggedToInt32: {
764 // Signed32 /\ Tagged -> Signed32 /\ UntaggedInt32 773 // Signed32 /\ Tagged -> Signed32 /\ UntaggedInt32
765 // TODO(neis): Activate once ChangeRepresentation works in typer. 774 // TODO(neis): Activate once ChangeRepresentation works in typer.
766 // Type* from = Type::Intersect(Type::Signed32(), Type::Tagged()); 775 // Type* from = Type::Intersect(Type::Signed32(), Type::Tagged());
767 // Type* to = Type::Intersect(Type::Signed32(), Type::UntaggedInt32()); 776 // Type* to = Type::Intersect(Type::Signed32(), Type::UntaggedInt32());
768 // CheckValueInputIs(node, 0, from)); 777 // CheckValueInputIs(node, 0, from));
769 // CheckUpperIs(node, to)); 778 // CheckUpperIs(node, to));
770 break; 779 break;
771 } 780 }
772 case IrOpcode::kChangeTaggedToUint32: { 781 case IrOpcode::kChangeTaggedToUint32: {
(...skipping 546 matching lines...) Expand 10 before | Expand all | Expand 10 after
1319 replacement->op()->EffectOutputCount() > 0); 1328 replacement->op()->EffectOutputCount() > 0);
1320 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1329 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1321 replacement->opcode() == IrOpcode::kFrameState); 1330 replacement->opcode() == IrOpcode::kFrameState);
1322 } 1331 }
1323 1332
1324 #endif // DEBUG 1333 #endif // DEBUG
1325 1334
1326 } // namespace compiler 1335 } // namespace compiler
1327 } // namespace internal 1336 } // namespace internal
1328 } // namespace v8 1337 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698