Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: ash/shelf/shelf_layout_manager.cc

Issue 1901773002: Removes most of aura dependencies from DefaultState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wm_window_positioner
Patch Set: comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/shelf/shelf_layout_manager.cc
diff --git a/ash/shelf/shelf_layout_manager.cc b/ash/shelf/shelf_layout_manager.cc
index 5d1bf3854614f004462f6b486159553e44fd9189..d3c4071a3437f2d41895db5d5d58e224909ae7f9 100644
--- a/ash/shelf/shelf_layout_manager.cc
+++ b/ash/shelf/shelf_layout_manager.cc
@@ -278,9 +278,10 @@ void ShelfLayoutManager::UpdateVisibilityState() {
} else {
// TODO(zelidrag): Verify shelf drag animation still shows on the device
// when we are in SHELF_AUTO_HIDE_ALWAYS_HIDDEN.
- WorkspaceWindowState window_state(workspace_controller_->GetWindowState());
+ wm::WorkspaceWindowState window_state(
+ workspace_controller_->GetWindowState());
switch (window_state) {
- case WORKSPACE_WINDOW_STATE_FULL_SCREEN: {
+ case wm::WORKSPACE_WINDOW_STATE_FULL_SCREEN: {
const aura::Window* fullscreen_window = GetRootWindowController(
root_window_)->GetWindowForFullscreenMode();
if (fullscreen_window && wm::GetWindowState(fullscreen_window)->
@@ -294,15 +295,15 @@ void ShelfLayoutManager::UpdateVisibilityState() {
break;
}
- case WORKSPACE_WINDOW_STATE_MAXIMIZED:
+ case wm::WORKSPACE_WINDOW_STATE_MAXIMIZED:
SetState(CalculateShelfVisibility());
break;
- case WORKSPACE_WINDOW_STATE_WINDOW_OVERLAPS_SHELF:
- case WORKSPACE_WINDOW_STATE_DEFAULT:
+ case wm::WORKSPACE_WINDOW_STATE_WINDOW_OVERLAPS_SHELF:
+ case wm::WORKSPACE_WINDOW_STATE_DEFAULT:
SetState(CalculateShelfVisibility());
- SetWindowOverlapsShelf(window_state ==
- WORKSPACE_WINDOW_STATE_WINDOW_OVERLAPS_SHELF);
+ SetWindowOverlapsShelf(
+ window_state == wm::WORKSPACE_WINDOW_STATE_WINDOW_OVERLAPS_SHELF);
break;
}
}
@@ -533,8 +534,9 @@ void ShelfLayoutManager::SetState(ShelfVisibilityState visibility_state) {
State state;
state.visibility_state = visibility_state;
state.auto_hide_state = CalculateAutoHideState(visibility_state);
- state.window_state = workspace_controller_ ?
- workspace_controller_->GetWindowState() : WORKSPACE_WINDOW_STATE_DEFAULT;
+ state.window_state = workspace_controller_
+ ? workspace_controller_->GetWindowState()
+ : wm::WORKSPACE_WINDOW_STATE_DEFAULT;
// Preserve the log in screen states.
state.is_adding_user_screen = state_.is_adding_user_screen;
state.is_screen_locked = state_.is_screen_locked;
@@ -574,7 +576,7 @@ void ShelfLayoutManager::SetState(ShelfVisibilityState visibility_state) {
// - Going from an auto hidden shelf in maximized mode to a visible shelf in
// maximized mode.
if (state.visibility_state == SHELF_VISIBLE &&
- state.window_state == WORKSPACE_WINDOW_STATE_MAXIMIZED &&
+ state.window_state == wm::WORKSPACE_WINDOW_STATE_MAXIMIZED &&
old_state.visibility_state != SHELF_VISIBLE) {
change_type = BACKGROUND_CHANGE_IMMEDIATE;
} else {
@@ -596,9 +598,9 @@ void ShelfLayoutManager::SetState(ShelfVisibilityState visibility_state) {
UpdateShelfBackground(change_type);
}
- shelf_->SetDimsShelf(
- state.visibility_state == SHELF_VISIBLE &&
- state.window_state == WORKSPACE_WINDOW_STATE_MAXIMIZED);
+ shelf_->SetDimsShelf(state.visibility_state == SHELF_VISIBLE &&
+ state.window_state ==
+ wm::WORKSPACE_WINDOW_STATE_MAXIMIZED);
TargetBounds target_bounds;
CalculateTargetBounds(state_, &target_bounds);
@@ -892,7 +894,7 @@ void ShelfLayoutManager::UpdateShelfBackground(
ShelfBackgroundType ShelfLayoutManager::GetShelfBackgroundType() const {
if (state_.visibility_state != SHELF_AUTO_HIDE &&
- state_.window_state == WORKSPACE_WINDOW_STATE_MAXIMIZED) {
+ state_.window_state == wm::WORKSPACE_WINDOW_STATE_MAXIMIZED) {
return SHELF_BACKGROUND_MAXIMIZED;
}

Powered by Google App Engine
This is Rietveld 408576698