Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1901753002: [compiler] Switch code printing to not use literal. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Switch code printing to not use literal. This switches CodeGenerator::PrintCode to be based on the allocated shared function info instead of the function literal. This is possible now that even live edit allocates a shared function info for scripts. R=ishell@chromium.org BUG=chromium:604375 LOG=n Committed: https://crrev.com/489d751efd8f631d4149b95ad7ff71a24d39e0c9 Cr-Commit-Position: refs/heads/master@{#35605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M src/codegen.cc View 2 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Note that the CL that unlocked this cleanup was landed just a couple of minutes ...
4 years, 8 months ago (2016-04-18 16:26:55 UTC) #1
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-18 16:31:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901753002/1
4 years, 8 months ago (2016-04-19 07:57:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 07:59:41 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 08:01:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/489d751efd8f631d4149b95ad7ff71a24d39e0c9
Cr-Commit-Position: refs/heads/master@{#35605}

Powered by Google App Engine
This is Rietveld 408576698