Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: tests/git_cl_test.py

Issue 1901733003: git_cl: description fetching from code review servers. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Small whitespace. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 8b00ac7e15647f8ff5a5f9aabf9cde1699feb363..571be654aa717d37e5f4fa1fd8680a1529d904cd 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -1381,6 +1381,48 @@ class TestGitCl(TestCase):
# super tedious.
self.assertEqual(0, git_cl.main(['set-commit', '-d']))
+ def test_description_display(self):
+ out = StringIO.StringIO()
+ self.mock(git_cl.sys, 'stdout', out)
+
+ class MockChangelist():
+ def __init__(self, **kwargs):
+ pass
+ def GetIssue(self):
+ return 1
+ def GetDescription(self):
+ return 'foo'
+
+ self.mock(git_cl, 'Changelist', MockChangelist)
+
+ self.assertEqual(0, git_cl.main(['description', '-d']))
+ self.assertEqual('foo\n', out.getvalue())
+
+ def test_description_rietveld(self):
+ out = StringIO.StringIO()
+ self.mock(git_cl.sys, 'stdout', out)
+ self.mock(git_cl.Changelist, 'GetDescription',
+ lambda *args: 'foobar')
+
+ self.calls = [
+ ((['git', 'config', 'rietveld.autoupdate'],), ''),
+ ((['git', 'config', 'rietveld.server'],), ''),
+ ((['git', 'config', 'rietveld.server'],), ''),
+ ]
+ self.assertEqual(0, git_cl.main([
+ 'description', 'https://code.review.org/123123', '-d', '--rietveld']))
+ self.assertEqual('foobar\n', out.getvalue())
+
+ def test_description_gerrit(self):
+ out = StringIO.StringIO()
+ self.mock(git_cl.sys, 'stdout', out)
+ self.mock(git_cl.Changelist, 'GetDescription',
+ lambda *args: 'foobar')
+
+ self.assertEqual(0, git_cl.main([
+ 'description', 'https://code.review.org/123123', '-d', '--gerrit']))
+ self.assertEqual('foobar\n', out.getvalue())
+
if __name__ == '__main__':
git_cl.logging.basicConfig(
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698