git_cl: description fetching from code review servers.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from distutils.version import LooseVersion
@@ skipping 3234 matching lines @@
         color, message['date'].split('.', 1)[0], message['sender'],
         Fore.RESET)
     if message['text'].strip():
       print '\n'.join('  ' + l for l in message['text'].splitlines())
   if options.json_file:
     with open(options.json_file, 'wb') as f:
       json.dump(summary, f)
   return 0
 
 
+@subcommand.usage('<codereview url or issue id>')

[tandrii(chromium), 2016/04/19 09:42:04]

wrap in [] to indicate optionality. by default, issue associated with branch is
used.

[martiniss, 2016/04/25 22:33:06]

Done.

 def CMDdescription(parser, args):
   """Brings up the editor for the current CL's description."""
   parser.add_option('-d', '--display', action='store_true',
                     help='Display the description instead of opening an editor')
+  parser.add_option('-i', '--issue',

[tandrii(chromium), 2016/04/19 09:42:04]

this contradicts the help above. IMO, choose either "-i <coderview url or issue
id> " or actual position arg.

[martiniss, 2016/04/25 22:33:06]

Removed.

+                    help='The issue to act on the description of')
+
+  _add_codereview_select_options(parser)
   auth.add_auth_options(parser)
-  options, _ = parser.parse_args(args)
+  options, args = parser.parse_args(args)
+  _process_codereview_select_options(parser, options)
+
+  target_issue = None
+  if options.issue:
+    issue_arg = ParseIssueNumberArgument(options.issue)
+    if not issue_arg.valid:
+      parser.print_help()
+      return 1
+    target_issue = issue_arg.issue

[tandrii(chromium), 2016/04/19 09:42:04]

you are potentially disregarding the codereview server here, but IMO, it's OK.

+
   auth_config = auth.extract_auth_config_from_options(options)
-  cl = Changelist(auth_config=auth_config)
+  kwargs = {
+    'auth_config': auth_config,
+    'issue': target_issue,
+    'codereview': options.forced_codereview,
+  }
+
+  cl = Changelist(**kwargs)

[tandrii(chromium), 2016/04/19 09:42:04]

you don't need kwargs var any more.

[martiniss, 2016/04/25 22:33:06]

Fixed.

   if not cl.GetIssue():
     DieWithError('This branch has no associated changelist.')
   description = ChangeDescription(cl.GetDescription())
   if options.display:
-    print description.description
+    print >> sys.stdout, description.description

[tandrii(chromium), 2016/04/19 09:42:04]

debug leftover?

[martiniss, 2016/04/25 22:33:06]

No, you need this to be able to mock it in the tests.

     return 0
   description.prompt()
   if cl.GetDescription() != description.description:
     cl.UpdateDescription(description.description)
   return 0
 
 
 def CreateDescriptionFromLog(args):
   """Pulls out the commit log to use as a base for the CL description."""
   log_args = []
@@ skipping 1547 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)