[generators] Perform state dispatch in loop header.

src/interpreter/control-flow-builders.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/control-flow-builders.h"
 
 namespace v8 {
 namespace internal {
 namespace interpreter {
 
@@ skipping 72 matching lines @@
 
 void BlockBuilder::EndBlock() {
   builder()->Bind(&block_end_);
   SetBreakTarget(block_end_);
 }
 
 
 LoopBuilder::~LoopBuilder() { DCHECK(continue_sites_.empty()); }
 
 
-void LoopBuilder::LoopHeader() {
+void LoopBuilder::LoopHeader(ZoneVector<BytecodeLabel>* additional_labels) {
   // Jumps from before the loop header into the loop violate ordering
   // requirements of bytecode basic blocks. The only entry into a loop
   // must be the loop header. Surely breaks is okay? Not if nested
   // and misplaced between the headers.
   DCHECK(break_sites_.empty() && continue_sites_.empty());
   builder()->Bind(&loop_header_);
+  for (auto& label : *additional_labels) {
+    builder()->Bind(loop_header_, &label);
+  }

[Jarin, 2016/04/26 12:59:51]

Any reason why you cannot bind in BytecodeGenerator::VisitIterationHeader?

[neis, 2016/04/26 14:59:10]

I can, but see the previous discussion.  I leave it up to Ross.

 }
 
 
 void LoopBuilder::EndLoop() {
   // Loop must have closed form, i.e. all loop elements are within the loop,
   // the loop header precedes the body and next elements in the loop.
   DCHECK(loop_header_.is_bound());
   builder()->Bind(&loop_end_);
   SetBreakTarget(loop_end_);
   if (next_.is_bound()) {
@@ skipping 74 matching lines @@
 }
 
 
 void TryFinallyBuilder::EndFinally() {
   // Nothing to be done here.
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8