Issue 1901693002: Cleanup: Remove references and unneeded includes of "base/scoped_ptr.h"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1901693002: Cleanup: Remove references and unneeded includes of "base/scoped_ptr.h" (Closed)

Created:
4 years, 8 months ago by alyssar1

Modified:
4 years, 8 months ago

Reviewers:
Ryan Hamilton, dcheng

CC:
dcheng, cbentzel+watch_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@119967190

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: Remove references and unneeded includes of "base/scoped_ptr.h" Merge internal change: 119917706 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 2

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	net/tools/quic/test_tools/packet_dropping_test_writer.h	View		2 chunks	+3 lines, -4 lines	2 comments	Download

Depends on Patchset:

Issue 1901673002 Patch 1

Dependent Patchsets:

Issue 1901723002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dcheng

https://codereview.chromium.org/1901693002/diff/1/net/tools/quic/test_tools/packet_dropping_test_writer.h File net/tools/quic/test_tools/packet_dropping_test_writer.h (left): https://codereview.chromium.org/1901693002/diff/1/net/tools/quic/test_tools/packet_dropping_test_writer.h#oldcode16 net/tools/quic/test_tools/packet_dropping_test_writer.h:16: #include "base/memory/scoped_ptr.h" #include <memory>

4 years, 8 months ago (2016-04-18 15:36:28 UTC) #3

Ryan Hamilton

4 years, 8 months ago (2016-04-18 22:01:52 UTC) #4

lgtm, mod one #include

https://codereview.chromium.org/1901693002/diff/1/net/tools/quic/test_tools/p...
File net/tools/quic/test_tools/packet_dropping_test_writer.h (left):

https://codereview.chromium.org/1901693002/diff/1/net/tools/quic/test_tools/p...
net/tools/quic/test_tools/packet_dropping_test_writer.h:16: #include
"base/memory/scoped_ptr.h"
On 2016/04/18 15:36:28, dcheng wrote:
> #include <memory>

Agreed.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages