Improve default value handling for SVGSVGElement.width/height

third_party/WebKit/Source/core/svg/SVGAnimatedLength.h

Index: third_party/WebKit/Source/core/svg/SVGAnimatedLength.h
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h
index ff630307bf83bc7d4480ba028e8d260a36a61c0b..a992ba7e7db92c26445b6112cd8b1a2a0ebc5359 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h
+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h
@@ -40,19 +40,23 @@ namespace blink {
 class SVGAnimatedLength : public SVGAnimatedProperty<SVGLength>, public ScriptWrappable {
     DEFINE_WRAPPERTYPEINFO();
 public:
-    static SVGAnimatedLength* create(SVGElement* contextElement, const QualifiedName& attributeName, SVGLength* initialValue)
+    static SVGAnimatedLength* create(SVGElement* contextElement, const QualifiedName& attributeName, SVGLength* initialValue, const char* defaultValue = nullptr)
     {
-        return new SVGAnimatedLength(contextElement, attributeName, initialValue);
+        return new SVGAnimatedLength(contextElement, attributeName, initialValue, defaultValue);
     }
 
+    void setDefaultValue();
     void setDefaultValueAsString(const String&);
     SVGParsingError setBaseValueAsString(const String&) override;
 
 protected:
-    SVGAnimatedLength(SVGElement* contextElement, const QualifiedName& attributeName, SVGLength* initialValue)
+    SVGAnimatedLength(SVGElement* contextElement, const QualifiedName& attributeName, SVGLength* initialValue, const char* defaultValue = nullptr)
         : SVGAnimatedProperty<SVGLength>(contextElement, attributeName, initialValue)
+        , m_defaultValue(defaultValue)
     {
     }
+
+    const char* m_defaultValue;

[pdr., 2016/04/18 21:25:14]

This seems like a memory regression since it costs one pointer per length. Is
there any other way to solve this, for example by special-casing
svgAttributeChanged?

[pdr., 2016/04/18 21:36:23]

Adding a little more info... I am wondering if we can avoid storing one default
per length, and instead store the default just once.

[fs, 2016/04/18 21:55:07]

We could probably fix it by a crutch in parseAttribute.
There are at least a few different methods (that I've been able to think of)
that avoids increasing the attribute objects. Some better and some worse I'm
sure - my current favorite is a "dictionary" (small index + string table).

 };
 
 } // namespace blink