third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html - Issue 1901673003: Improve default value handling for SVGSVGElement.width/height

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html

Issue 1901673003: Improve default value handling for SVGSVGElement.width/height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweak old test. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/attribute-default-value-after-removal-expected.html ('k') | third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs-expected.txt » ('j') | third_party/WebKit/Source/core/svg/SVGAnimatedLength.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html

diff --git a/third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html b/third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html

index 6342b5ccf1b52b481c9763cb081aeb6049342cd6..0615823df26c6da7979dbc3ec6e1b9d371d7877e 100644

--- a/third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html

+++ b/third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html

@@ -28,7 +28,7 @@

invalid_widths.forEach(function(invalid_width) {

setWidth('#svg', invalid_width);

test(function() {

- assert_equals(getWidth('#svg'), 0);

+ assert_equals(getWidth('#svg'), document.body.clientWidth);

}, "Test width '" + invalid_width + "' on SVGSVGElement");

setWidth('#fO', invalid_width);