Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 1901673003: Improve default value handling for SVGSVGElement.width/height (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweak old test. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2010 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2007 Apple Inc. All rights reserved.
5 * Copyright (C) 2014 Google, Inc. 5 * Copyright (C) 2014 Google, Inc.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 #include "platform/transforms/AffineTransform.h" 57 #include "platform/transforms/AffineTransform.h"
58 #include "wtf/StdLibExtras.h" 58 #include "wtf/StdLibExtras.h"
59 59
60 namespace blink { 60 namespace blink {
61 61
62 inline SVGSVGElement::SVGSVGElement(Document& doc) 62 inline SVGSVGElement::SVGSVGElement(Document& doc)
63 : SVGGraphicsElement(SVGNames::svgTag, doc) 63 : SVGGraphicsElement(SVGNames::svgTag, doc)
64 , SVGFitToViewBox(this) 64 , SVGFitToViewBox(this)
65 , m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(SVG LengthMode::Width))) 65 , m_x(SVGAnimatedLength::create(this, SVGNames::xAttr, SVGLength::create(SVG LengthMode::Width)))
66 , m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(SVG LengthMode::Height))) 66 , m_y(SVGAnimatedLength::create(this, SVGNames::yAttr, SVGLength::create(SVG LengthMode::Height)))
67 , m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::cr eate(SVGLengthMode::Width))) 67 , m_width(SVGAnimatedLength::create(this, SVGNames::widthAttr, SVGLength::cr eate(SVGLengthMode::Width), "100%"))
68 , m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength:: create(SVGLengthMode::Height))) 68 , m_height(SVGAnimatedLength::create(this, SVGNames::heightAttr, SVGLength:: create(SVGLengthMode::Height), "100%"))
69 , m_useCurrentView(false) 69 , m_useCurrentView(false)
70 , m_timeContainer(SMILTimeContainer::create(*this)) 70 , m_timeContainer(SMILTimeContainer::create(*this))
71 , m_translation(SVGPoint::create()) 71 , m_translation(SVGPoint::create())
72 , m_currentScale(1) 72 , m_currentScale(1)
73 { 73 {
74 m_width->setDefaultValueAsString("100%"); 74 m_width->setDefaultValue();
75 m_height->setDefaultValueAsString("100%"); 75 m_height->setDefaultValue();
76 76
77 addToPropertyMap(m_x); 77 addToPropertyMap(m_x);
78 addToPropertyMap(m_y); 78 addToPropertyMap(m_y);
79 addToPropertyMap(m_width); 79 addToPropertyMap(m_width);
80 addToPropertyMap(m_height); 80 addToPropertyMap(m_height);
81 81
82 UseCounter::count(doc, UseCounter::SVGSVGElement); 82 UseCounter::count(doc, UseCounter::SVGSVGElement);
83 } 83 }
84 84
85 DEFINE_NODE_FACTORY(SVGSVGElement) 85 DEFINE_NODE_FACTORY(SVGSVGElement)
(...skipping 645 matching lines...) Expand 10 before | Expand all | Expand 10 after
731 visitor->trace(m_width); 731 visitor->trace(m_width);
732 visitor->trace(m_height); 732 visitor->trace(m_height);
733 visitor->trace(m_translation); 733 visitor->trace(m_translation);
734 visitor->trace(m_timeContainer); 734 visitor->trace(m_timeContainer);
735 visitor->trace(m_viewSpec); 735 visitor->trace(m_viewSpec);
736 SVGGraphicsElement::trace(visitor); 736 SVGGraphicsElement::trace(visitor);
737 SVGFitToViewBox::trace(visitor); 737 SVGFitToViewBox::trace(visitor);
738 } 738 }
739 739
740 } // namespace blink 740 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698