Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java

Issue 1901623002: Unified Bookmarks and Recent Tabs signin methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java
index a301e5523d9ca5ec3cdd7ae9f8f0d20230e69429..bad325dfbfbe289be2305c4b0af71babc5c74f8f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsRowAdapter.java
@@ -27,8 +27,9 @@ import org.chromium.chrome.browser.favicon.FaviconHelper.FaviconImageCallback;
import org.chromium.chrome.browser.ntp.ForeignSessionHelper.ForeignSession;
import org.chromium.chrome.browser.ntp.ForeignSessionHelper.ForeignSessionTab;
import org.chromium.chrome.browser.ntp.ForeignSessionHelper.ForeignSessionWindow;
-import org.chromium.chrome.browser.ntp.RecentTabsPromoView.UserActionListener;
import org.chromium.chrome.browser.ntp.RecentlyClosedBridge.RecentlyClosedTab;
+import org.chromium.chrome.browser.signin.SigninAccessPoint;
+import org.chromium.chrome.browser.signin.SigninAndSyncView;
import org.chromium.ui.WindowOpenDisposition;
import org.chromium.ui.base.DeviceFormFactor;
@@ -593,20 +594,16 @@ public class RecentTabsRowAdapter extends BaseExpandableListAdapter {
View getChildView(int childPosition, boolean isLastChild, View convertView,
ViewGroup parent) {
if (convertView == null) {
- convertView = new RecentTabsPromoView(
- mActivity, mRecentTabsManager, new UserActionListener() {
- @Override
- public void onAccountSelectionConfirmed() {
- RecordUserAction.record("Signin_Signin_FromRecentTabs");
- }
- @Override
- public void onNewAccount() {}
- @Override
- public void onAccountSelectionCancelled() {
- mRecentTabsManager.setSigninPromoDeclined();
- notifyDataSetChanged();
- }
- });
+ SigninAndSyncView.Listener listener = new SigninAndSyncView.Listener() {
+ @Override
+ public void onViewDismissed() {
+ mRecentTabsManager.setSigninPromoDeclined();
+ notifyDataSetChanged();
+ }
+ };
+
+ convertView =
+ new SigninAndSyncView(mActivity, listener, SigninAccessPoint.RECENT_TABS);
}
if (!mRecentTabsManager.isSignedIn()) {
RecordUserAction.record("Signin_Impression_FromRecentTabs");

Powered by Google App Engine
This is Rietveld 408576698