Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java

Issue 1901623002: Unified Bookmarks and Recent Tabs signin methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java
deleted file mode 100644
index e84fcd7bdd27f145444b9017a18a29853af2c95e..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSigninActivity.java
+++ /dev/null
@@ -1,149 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.bookmarks;
-
-import android.os.Bundle;
-
-import org.chromium.base.ObserverList;
-import org.chromium.base.metrics.RecordUserAction;
-import org.chromium.chrome.browser.firstrun.ProfileDataCache;
-import org.chromium.chrome.browser.ntp.RecentTabsPromoView;
-import org.chromium.chrome.browser.ntp.RecentTabsPromoView.SyncPromoModel;
-import org.chromium.chrome.browser.ntp.RecentTabsPromoView.UserActionListener;
-import org.chromium.chrome.browser.profiles.Profile;
-import org.chromium.chrome.browser.signin.SigninAccessPoint;
-import org.chromium.chrome.browser.signin.SigninManager;
-import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
-import org.chromium.chrome.browser.sync.ProfileSyncService;
-import org.chromium.sync.AndroidSyncSettings;
-import org.chromium.sync.AndroidSyncSettings.AndroidSyncSettingsObserver;
-import org.chromium.sync.signin.ChromeSigninController;
-
-/**
- * Sign in promotion activity that is triggered from bookmark UI.
- */
-public class BookmarkSigninActivity extends BookmarkActivityBase implements
- AndroidSyncSettingsObserver, SignInStateObserver, SyncPromoModel, UserActionListener {
- private SigninManager mSignInManager;
- private ProfileDataCache mProfileDataCache;
- private final ObserverList<AndroidSyncSettingsObserver> mObservers =
- new ObserverList<AndroidSyncSettingsObserver>();
-
- @Override
- public void onCreate(Bundle savedInstanceState) {
- super.onCreate(savedInstanceState);
- if (savedInstanceState == null) {
- RecordUserAction.record("Stars_SignInPromoActivity_Launched");
- }
-
- setContentView(new RecentTabsPromoView(this, this, this));
-
- AndroidSyncSettings.registerObserver(this, this);
-
- mSignInManager = SigninManager.get(this);
- mSignInManager.addSignInStateObserver(this);
-
- // This signin activity shouldn't be created if user is signed in already, but for just in
- // case it was signed in just before onCreate somehow.
- if (isSignedIn()) finish();
- }
-
- @Override
- public void onDestroy() {
- super.onDestroy();
- AndroidSyncSettings.unregisterObserver(this, this);
-
- mSignInManager.removeSignInStateObserver(this);
- mSignInManager = null;
-
- if (mProfileDataCache != null) {
- mProfileDataCache.destroy();
- mProfileDataCache = null;
- }
- }
-
- // AndroidSyncSettingsObserver
-
- @Override
- public void androidSyncSettingsChanged() {
- for (AndroidSyncSettingsObserver observer : mObservers) {
- observer.androidSyncSettingsChanged();
- }
- }
-
- // SignInStateObserver
-
- @Override
- public void onSignedIn() {
- androidSyncSettingsChanged();
- finish();
- }
-
- @Override
- public void onSignedOut() {
- assert false : "onSignedOut() called on signin activity.";
- }
-
- // SyncPromoModel
-
- @Override
- public boolean isSyncEnabled() {
- return AndroidSyncSettings.isSyncEnabled(this);
- }
-
- @Override
- public boolean isSignedIn() {
- return ChromeSigninController.get(this).isSignedIn();
- }
-
- @Override
- public void enableSync() {
- ProfileSyncService syncService = ProfileSyncService.get();
- if (syncService != null) {
- syncService.requestStart();
- }
- }
-
- @Override
- public void registerForSyncUpdates(AndroidSyncSettingsObserver changeListener) {
- mObservers.addObserver(changeListener);
- }
-
- @Override
- public void unregisterForSyncUpdates(AndroidSyncSettingsObserver changeListener) {
- mObservers.removeObserver(changeListener);
- }
-
- // UserActionListener
-
- @Override
- public void onAccountSelectionConfirmed() {
- RecordUserAction.record("Stars_SignInPromoActivity_SignedIn");
- RecordUserAction.record("Signin_Signin_FromBookmarkManager");
- }
-
- @Override
- public void onNewAccount() {
- RecordUserAction.record("Stars_SignInPromoActivity_NewAccount");
- }
-
- @Override
- public void onAccountSelectionCancelled() {
- finish();
- };
-
- @Override
- public ProfileDataCache getProfileDataCache() {
- if (mProfileDataCache == null) {
- mProfileDataCache = new ProfileDataCache(this, Profile.getLastUsedProfile());
- }
- return mProfileDataCache;
- }
-
- @Override
- public int getAccessPoint() {
- return SigninAccessPoint.BOOKMARK_MANAGER;
- }
-}

Powered by Google App Engine
This is Rietveld 408576698