Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 1901593005: PPC: [regexp] do not assume short external strings have a minimum size. (Closed)

Created:
4 years, 8 months ago by JaideepBajwa
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [regexp] do not assume short external strings have a minimum size. Port 3518e492c0939759ae1a2623bbd606646ee172f1 Original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4923, chromium:604897 LOG=N Committed: https://crrev.com/7d8e279a7b11cb3c1cbeb424118a20210f9b8eea Cr-Commit-Position: refs/heads/master@{#35671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -39 lines) Patch
M src/ppc/code-stubs-ppc.cc View 4 chunks +29 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 8 months ago (2016-04-20 16:06:49 UTC) #1
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-20 16:26:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901593005/1
4 years, 8 months ago (2016-04-20 16:30:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 16:52:43 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:13:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d8e279a7b11cb3c1cbeb424118a20210f9b8eea
Cr-Commit-Position: refs/heads/master@{#35671}

Powered by Google App Engine
This is Rietveld 408576698