Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: media/audio/audio_input_controller_unittest.cc

Issue 1901583005: Revert of Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/android/audio_manager_android.cc ('k') | media/audio/audio_input_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_input_controller_unittest.cc
diff --git a/media/audio/audio_input_controller_unittest.cc b/media/audio/audio_input_controller_unittest.cc
index 36ebc02cd14d0d2d82273471ab0fdd6d3bea4042..6a35d87c9a3528afde811e810a3be263c25e472c 100644
--- a/media/audio/audio_input_controller_unittest.cc
+++ b/media/audio/audio_input_controller_unittest.cc
@@ -67,20 +67,11 @@
// Test fixture.
class AudioInputControllerTest : public testing::Test {
public:
- AudioInputControllerTest()
- : audio_manager_(
- AudioManager::CreateForTesting(message_loop_.task_runner())) {
- // Flush the message loop to ensure that AudioManager is fully initialized.
- message_loop_.RunUntilIdle();
- }
- ~AudioInputControllerTest() override {
- audio_manager_.reset();
- message_loop_.RunUntilIdle();
- }
+ AudioInputControllerTest() {}
+ ~AudioInputControllerTest() override {}
protected:
base::MessageLoop message_loop_;
- ScopedAudioManagerPtr audio_manager_;
private:
DISALLOW_COPY_AND_ASSIGN(AudioInputControllerTest);
@@ -94,12 +85,16 @@
EXPECT_CALL(event_handler, OnCreated(NotNull()))
.WillOnce(QuitMessageLoop(&message_loop_));
+ scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
kSampleRate, kBitsPerSample, kSamplesPerPacket);
scoped_refptr<AudioInputController> controller =
- AudioInputController::Create(audio_manager_.get(), &event_handler, params,
- AudioManagerBase::kDefaultDeviceId, NULL);
+ AudioInputController::Create(audio_manager.get(),
+ &event_handler,
+ params,
+ AudioManagerBase::kDefaultDeviceId,
+ NULL);
ASSERT_TRUE(controller.get());
// Wait for OnCreated() to fire.
@@ -128,13 +123,17 @@
.WillRepeatedly(CheckCountAndPostQuitTask(
&count, 10, message_loop_.task_runner()));
+ scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
kSampleRate, kBitsPerSample, kSamplesPerPacket);
// Creating the AudioInputController should render an OnCreated() call.
scoped_refptr<AudioInputController> controller =
- AudioInputController::Create(audio_manager_.get(), &event_handler, params,
- AudioManagerBase::kDefaultDeviceId, NULL);
+ AudioInputController::Create(audio_manager.get(),
+ &event_handler,
+ params,
+ AudioManagerBase::kDefaultDeviceId,
+ NULL);
ASSERT_TRUE(controller.get());
// Start recording and trigger one OnRecording() call.
@@ -177,13 +176,17 @@
.Times(Exactly(1))
.WillOnce(QuitMessageLoop(&message_loop_));
+ scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
AudioParameters params(AudioParameters::AUDIO_FAKE, kChannelLayout,
kSampleRate, kBitsPerSample, kSamplesPerPacket);
// Creating the AudioInputController should render an OnCreated() call.
scoped_refptr<AudioInputController> controller =
- AudioInputController::Create(audio_manager_.get(), &event_handler, params,
- AudioManagerBase::kDefaultDeviceId, NULL);
+ AudioInputController::Create(audio_manager.get(),
+ &event_handler,
+ params,
+ AudioManagerBase::kDefaultDeviceId,
+ NULL);
ASSERT_TRUE(controller.get());
// Start recording and trigger one OnRecording() call.
@@ -210,14 +213,18 @@
EXPECT_CALL(event_handler, OnCreated(NotNull()))
.Times(Exactly(0));
+ scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
AudioParameters params(AudioParameters::AUDIO_FAKE,
kChannelLayout,
kSampleRate,
kBitsPerSample,
kSamplesPerPacket * 1000);
scoped_refptr<AudioInputController> controller =
- AudioInputController::Create(audio_manager_.get(), &event_handler, params,
- AudioManagerBase::kDefaultDeviceId, NULL);
+ AudioInputController::Create(audio_manager.get(),
+ &event_handler,
+ params,
+ AudioManagerBase::kDefaultDeviceId,
+ NULL);
ASSERT_FALSE(controller.get());
}
@@ -232,14 +239,18 @@
EXPECT_CALL(event_handler, OnRecording(NotNull()))
.Times(Exactly(1));
+ scoped_ptr<AudioManager> audio_manager(AudioManager::CreateForTesting());
AudioParameters params(AudioParameters::AUDIO_FAKE,
kChannelLayout,
kSampleRate,
kBitsPerSample,
kSamplesPerPacket);
scoped_refptr<AudioInputController> controller =
- AudioInputController::Create(audio_manager_.get(), &event_handler, params,
- AudioManagerBase::kDefaultDeviceId, NULL);
+ AudioInputController::Create(audio_manager.get(),
+ &event_handler,
+ params,
+ AudioManagerBase::kDefaultDeviceId,
+ NULL);
ASSERT_TRUE(controller.get());
controller->Record();
« no previous file with comments | « media/audio/android/audio_manager_android.cc ('k') | media/audio/audio_input_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698