Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: media/audio/win/audio_manager_win.cc

Issue 1901583005: Revert of Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/audio/win/audio_manager_win.h ('k') | media/audio/win/audio_output_win_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/audio_io.h" 5 #include "media/audio/audio_io.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <objbase.h> // This has to be before initguid.h 8 #include <objbase.h> // This has to be before initguid.h
9 #include <initguid.h> 9 #include <initguid.h>
10 #include <mmsystem.h> 10 #include <mmsystem.h>
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 119
120 // Use 4 buffers for Vista, 3 for everyone else: 120 // Use 4 buffers for Vista, 3 for everyone else:
121 // - The entire Windows audio stack was rewritten for Windows Vista and wave 121 // - The entire Windows audio stack was rewritten for Windows Vista and wave
122 // out performance was degraded compared to XP. 122 // out performance was degraded compared to XP.
123 // - The regression was fixed in Windows 7 and most configurations will work 123 // - The regression was fixed in Windows 7 and most configurations will work
124 // with 2, but some (e.g., some Sound Blasters) still need 3. 124 // with 2, but some (e.g., some Sound Blasters) still need 3.
125 // - Some XP configurations (even multi-processor ones) also need 3. 125 // - Some XP configurations (even multi-processor ones) also need 3.
126 return (base::win::GetVersion() == base::win::VERSION_VISTA) ? 4 : 3; 126 return (base::win::GetVersion() == base::win::VERSION_VISTA) ? 4 : 3;
127 } 127 }
128 128
129 AudioManagerWin::AudioManagerWin( 129 AudioManagerWin::AudioManagerWin(AudioLogFactory* audio_log_factory)
130 scoped_refptr<base::SingleThreadTaskRunner> task_runner, 130 : AudioManagerBase(audio_log_factory),
131 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
132 AudioLogFactory* audio_log_factory)
133 : AudioManagerBase(std::move(task_runner),
134 std::move(worker_task_runner),
135 audio_log_factory),
136 // |CoreAudioUtil::IsSupported()| uses static variables to avoid doing 131 // |CoreAudioUtil::IsSupported()| uses static variables to avoid doing
137 // multiple initializations. This is however not thread safe. 132 // multiple initializations. This is however not thread safe.
138 // So, here we call it explicitly before we kick off the audio thread 133 // So, here we call it explicitly before we kick off the audio thread
139 // or do any other work. 134 // or do any other work.
140 enumeration_type_(CoreAudioUtil::IsSupported() ? kMMDeviceEnumeration 135 enumeration_type_(CoreAudioUtil::IsSupported() ?
141 : kWaveEnumeration) { 136 kMMDeviceEnumeration : kWaveEnumeration) {
142 SetMaxOutputStreamsAllowed(kMaxOutputStreams); 137 SetMaxOutputStreamsAllowed(kMaxOutputStreams);
143 138
144 // WARNING: This is executed on the UI loop, do not add any code here which 139 // WARNING: This is executed on the UI loop, do not add any code here which
145 // loads libraries or attempts to call out into the OS. Instead add such code 140 // loads libraries or attempts to call out into the OS. Instead add such code
146 // to the InitializeOnAudioThread() method below. 141 // to the InitializeOnAudioThread() method below.
147 142
148 // Task must be posted last to avoid races from handing out "this" to the 143 // Task must be posted last to avoid races from handing out "this" to the
149 // audio thread. 144 // audio thread.
150 GetTaskRunner()->PostTask(FROM_HERE, base::Bind( 145 GetTaskRunner()->PostTask(FROM_HERE, base::Bind(
151 &AudioManagerWin::InitializeOnAudioThread, base::Unretained(this))); 146 &AudioManagerWin::InitializeOnAudioThread, base::Unretained(this)));
152 } 147 }
153 148
154 AudioManagerWin::~AudioManagerWin() { 149 AudioManagerWin::~AudioManagerWin() {
150 // It's safe to post a task here since Shutdown() will wait for all tasks to
151 // complete before returning.
152 GetTaskRunner()->PostTask(FROM_HERE, base::Bind(
153 &AudioManagerWin::ShutdownOnAudioThread, base::Unretained(this)));
155 Shutdown(); 154 Shutdown();
156 } 155 }
157 156
158 bool AudioManagerWin::HasAudioOutputDevices() { 157 bool AudioManagerWin::HasAudioOutputDevices() {
159 return (::waveOutGetNumDevs() != 0); 158 return (::waveOutGetNumDevs() != 0);
160 } 159 }
161 160
162 bool AudioManagerWin::HasAudioInputDevices() { 161 bool AudioManagerWin::HasAudioInputDevices() {
163 return (::waveInGetNumDevs() != 0); 162 return (::waveInGetNumDevs() != 0);
164 } 163 }
165 164
166 void AudioManagerWin::InitializeOnAudioThread() { 165 void AudioManagerWin::InitializeOnAudioThread() {
167 DCHECK(GetTaskRunner()->BelongsToCurrentThread()); 166 DCHECK(GetTaskRunner()->BelongsToCurrentThread());
168 167
169 if (core_audio_supported()) { 168 if (core_audio_supported()) {
170 // AudioDeviceListenerWin must be initialized on a COM thread and should 169 // AudioDeviceListenerWin must be initialized on a COM thread and should
171 // only be used if WASAPI / Core Audio is supported. 170 // only be used if WASAPI / Core Audio is supported.
172 output_device_listener_.reset(new AudioDeviceListenerWin(BindToCurrentLoop( 171 output_device_listener_.reset(new AudioDeviceListenerWin(BindToCurrentLoop(
173 base::Bind(&AudioManagerWin::NotifyAllOutputDeviceChangeListeners, 172 base::Bind(&AudioManagerWin::NotifyAllOutputDeviceChangeListeners,
174 base::Unretained(this))))); 173 base::Unretained(this)))));
175 } 174 }
176 } 175 }
177 176
177 void AudioManagerWin::ShutdownOnAudioThread() {
178 DCHECK(GetTaskRunner()->BelongsToCurrentThread());
179 output_device_listener_.reset();
180 }
181
178 base::string16 AudioManagerWin::GetAudioInputDeviceModel() { 182 base::string16 AudioManagerWin::GetAudioInputDeviceModel() {
179 // Get the default audio capture device and its device interface name. 183 // Get the default audio capture device and its device interface name.
180 DWORD device_id = 0; 184 DWORD device_id = 0;
181 waveInMessage(reinterpret_cast<HWAVEIN>(WAVE_MAPPER), 185 waveInMessage(reinterpret_cast<HWAVEIN>(WAVE_MAPPER),
182 DRVM_MAPPER_PREFERRED_GET, 186 DRVM_MAPPER_PREFERRED_GET,
183 reinterpret_cast<DWORD_PTR>(&device_id), NULL); 187 reinterpret_cast<DWORD_PTR>(&device_id), NULL);
184 ULONG device_interface_name_size = 0; 188 ULONG device_interface_name_size = 0;
185 waveInMessage(reinterpret_cast<HWAVEIN>(device_id), 189 waveInMessage(reinterpret_cast<HWAVEIN>(device_id),
186 DRV_QUERYDEVICEINTERFACESIZE, 190 DRV_QUERYDEVICEINTERFACESIZE,
187 reinterpret_cast<DWORD_PTR>(&device_interface_name_size), 0); 191 reinterpret_cast<DWORD_PTR>(&device_interface_name_size), 0);
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 << device_id; 530 << device_id;
527 return NULL; 531 return NULL;
528 } 532 }
529 } 533 }
530 534
531 return new PCMWaveInAudioInputStream(this, params, kNumInputBuffers, 535 return new PCMWaveInAudioInputStream(this, params, kNumInputBuffers,
532 xp_device_id); 536 xp_device_id);
533 } 537 }
534 538
535 /// static 539 /// static
536 ScopedAudioManagerPtr CreateAudioManager( 540 AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) {
537 scoped_refptr<base::SingleThreadTaskRunner> task_runner, 541 return new AudioManagerWin(audio_log_factory);
538 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
539 AudioLogFactory* audio_log_factory) {
540 return ScopedAudioManagerPtr(
541 new AudioManagerWin(std::move(task_runner), std::move(worker_task_runner),
542 audio_log_factory));
543 } 542 }
544 543
545 } // namespace media 544 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/win/audio_manager_win.h ('k') | media/audio/win/audio_output_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698