Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: media/audio/linux/audio_manager_linux.cc

Issue 1901583005: Revert of Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/audio/fake_audio_manager.cc ('k') | media/audio/mac/audio_auhal_mac_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/metrics/histogram.h" 6 #include "base/metrics/histogram.h"
7 #include "media/base/media_switches.h"
8
9 #if defined(USE_ALSA) 7 #if defined(USE_ALSA)
10 #include "media/audio/alsa/audio_manager_alsa.h" 8 #include "media/audio/alsa/audio_manager_alsa.h"
11 #else 9 #else
12 #include "media/audio/fake_audio_manager.h" 10 #include "media/audio/fake_audio_manager.h"
13 #endif 11 #endif
14 #if defined(USE_CRAS) 12 #if defined(USE_CRAS)
15 #include "media/audio/cras/audio_manager_cras.h" 13 #include "media/audio/cras/audio_manager_cras.h"
16 #endif 14 #endif
17 #if defined(USE_PULSEAUDIO) 15 #if defined(USE_PULSEAUDIO)
18 #include "media/audio/pulse/audio_manager_pulse.h" 16 #include "media/audio/pulse/audio_manager_pulse.h"
19 #endif 17 #endif
18 #include "media/base/media_switches.h"
20 19
21 namespace media { 20 namespace media {
22 21
23 enum LinuxAudioIO { 22 enum LinuxAudioIO {
24 kPulse, 23 kPulse,
25 kAlsa, 24 kAlsa,
26 kCras, 25 kCras,
27 kAudioIOMax = kCras // Must always be equal to largest logged entry. 26 kAudioIOMax = kCras // Must always be equal to largest logged entry.
28 }; 27 };
29 28
30 ScopedAudioManagerPtr CreateAudioManager( 29 AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) {
31 scoped_refptr<base::SingleThreadTaskRunner> task_runner,
32 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
33 AudioLogFactory* audio_log_factory) {
34 #if defined(USE_CRAS) 30 #if defined(USE_CRAS)
35 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) { 31 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) {
36 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1); 32 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1);
37 return ScopedAudioManagerPtr( 33 return new AudioManagerCras(audio_log_factory);
38 new AudioManagerCras(std::move(task_runner),
39 std::move(worker_task_runner), audio_log_factory));
40 } 34 }
41 #endif 35 #endif
42 36
43 #if defined(USE_PULSEAUDIO) 37 #if defined(USE_PULSEAUDIO)
44 // Do not move task runners when creating AudioManagerPulse. 38 AudioManager* manager = AudioManagerPulse::Create(audio_log_factory);
45 // If the creation fails, we need to use the task runners to create other 39 if (manager) {
46 // AudioManager implementations.
47 std::unique_ptr<AudioManagerPulse, AudioManagerDeleter> manager(
48 new AudioManagerPulse(task_runner, worker_task_runner,
49 audio_log_factory));
50 if (manager->Init()) {
51 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1); 40 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1);
52 return std::move(manager); 41 return manager;
53 } 42 }
54 DVLOG(1) << "PulseAudio is not available on the OS";
55 #endif 43 #endif
56 44
57 #if defined(USE_ALSA) 45 #if defined(USE_ALSA)
58 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1); 46 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1);
59 return ScopedAudioManagerPtr( 47 return new AudioManagerAlsa(audio_log_factory);
60 new AudioManagerAlsa(std::move(task_runner),
61 std::move(worker_task_runner), audio_log_factory));
62 #else 48 #else
63 return ScopedAudioManagerPtr( 49 return new FakeAudioManager(audio_log_factory);
64 new FakeAudioManager(std::move(task_runner),
65 std::move(worker_task_runner), audio_log_factory));
66 #endif 50 #endif
67 } 51 }
68 52
69 } // namespace media 53 } // namespace media
OLDNEW
« no previous file with comments | « media/audio/fake_audio_manager.cc ('k') | media/audio/mac/audio_auhal_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698