Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1901573002: Reland of Immediately cache compiled scripts. (Closed)

Created:
4 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 8 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Immediately cache compiled scripts. (patchset #1 id:1 of https://codereview.chromium.org/1882833006/ ) Reason for revert: Fixed webkit_unit_tests Original issue's description: > Revert of Immediately cache compiled scripts. (patchset #2 id:20001 of https://codereview.chromium.org/1890083002/ ) > > Reason for revert: > [Sheriff] Breaks: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/8769 > > Auto-bisect points to this CL. > > Original issue's description: > > Immediately cache compiled scripts. > > > > Usually, script compilation is expensive enough to warrant the extra > > overhead of caching scripts immediatly. > > > > BUG=chromium:588900 > > R=yangguo@chromium.org > > LOG=n > > > > Committed: https://crrev.com/3533c084d470912384988768c4b3b109304da357 > > Cr-Commit-Position: refs/heads/master@{#35527} > > TBR=yangguo@chromium.org,jochen@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:588900 > > Committed: https://crrev.com/f8a5a4da70d0a8e6dbb1b5c633c2b6b47fe5c3f6 > Cr-Commit-Position: refs/heads/master@{#35536} TBR=yangguo@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:588900 LOG=n Committed: https://crrev.com/a142dedaff754e8fdae90da96daf357ed3aaa27d Cr-Commit-Position: refs/heads/master@{#35566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -62 lines) Patch
M src/objects.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +1 line, -45 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
jochen (gone - plz use gerrit)
Created Reland of Immediately cache compiled scripts.
4 years, 8 months ago (2016-04-18 07:00:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901573002/1
4 years, 8 months ago (2016-04-18 07:01:15 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13762)
4 years, 8 months ago (2016-04-18 07:05:05 UTC) #5
Michael Achenbach
What is with https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/8769 - is this fixed too?
4 years, 8 months ago (2016-04-18 07:08:36 UTC) #6
Yang
On 2016/04/18 07:08:36, Michael Achenbach wrote: > What is with > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug/builds/8769 > - is ...
4 years, 8 months ago (2016-04-18 08:00:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901573002/1
4 years, 8 months ago (2016-04-18 08:51:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13767)
4 years, 8 months ago (2016-04-18 08:55:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901573002/1
4 years, 8 months ago (2016-04-18 08:58:35 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 09:00:33 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 09:01:18 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a142dedaff754e8fdae90da96daf357ed3aaa27d
Cr-Commit-Position: refs/heads/master@{#35566}

Powered by Google App Engine
This is Rietveld 408576698