Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Issue 1901513003: Re-land: "Use a token to initialise ChannelMojo and MojoApplication everywhere." (Closed)

Created:
4 years, 8 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: "Use a token to initialise ChannelMojo and MojoApplication everywhere." Was reverted as a potential cause of a Mac issue. This change was not responsible for the breakage, and hence re-landing. BUG=None Committed: https://crrev.com/8c3af5ae353ec2dd50733e3aef2084d10d99ecf1 Cr-Commit-Position: refs/heads/master@{#388077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -328 lines) Patch
M content/browser/gpu/gpu_process_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 6 chunks +7 lines, -17 lines 0 comments Download
M content/browser/mojo/mojo_application_host.h View 3 chunks +8 lines, -26 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 2 chunks +5 lines, -56 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 6 chunks +6 lines, -21 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 5 chunks +7 lines, -9 lines 0 comments Download
M content/child/mojo/mojo_application.h View 1 chunk +7 lines, -25 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 2 chunks +3 lines, -44 lines 0 comments Download
M content/common/content_message_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/in_process_child_thread_params.h View 4 chunks +3 lines, -4 lines 0 comments Download
M content/common/in_process_child_thread_params.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/mojo/channel_init.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/common/mojo/channel_init.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D content/common/mojo/mojo_messages.h View 1 chunk +0 lines, -22 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.h View 3 chunks +8 lines, -4 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Anand Mistry (off Chromium)
tsepez@chromium.org: IPC messages. jam@chromium.org: Everywhere else. avi@ was the original reviewer, but he appears to ...
4 years, 8 months ago (2016-04-18 01:49:01 UTC) #2
jam
On 2016/04/18 01:49:01, Anand Mistry wrote: > mailto:tsepez@chromium.org: IPC messages. > mailto:jam@chromium.org: Everywhere else. avi@ ...
4 years, 8 months ago (2016-04-18 16:45:36 UTC) #3
Tom Sepez
stampy stamp LGTM
4 years, 8 months ago (2016-04-18 16:46:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901513003/1
4 years, 8 months ago (2016-04-18 23:29:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 23:35:36 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 23:37:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c3af5ae353ec2dd50733e3aef2084d10d99ecf1
Cr-Commit-Position: refs/heads/master@{#388077}

Powered by Google App Engine
This is Rietveld 408576698