Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901473007: Remove unnecessary Platform::loadResource override (Closed)

Created:
4 years, 8 months ago by kinuko
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary Platform::loadResource override BUG=n/a Committed: https://crrev.com/065a732e785c8791d240ccf71e2bee3260af8111 Cr-Commit-Position: refs/heads/master@{#388622}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M content/test/test_blink_web_unit_test_support.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901473007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901473007/1
4 years, 8 months ago (2016-04-19 15:50:55 UTC) #2
kinuko
Very minor cleanup only; ptl
4 years, 8 months ago (2016-04-19 15:57:54 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 16:47:56 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-20 14:25:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901473007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901473007/1
4 years, 8 months ago (2016-04-20 23:07:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:18:06 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:25 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/065a732e785c8791d240ccf71e2bee3260af8111
Cr-Commit-Position: refs/heads/master@{#388622}

Powered by Google App Engine
This is Rietveld 408576698