Issue 1901423003: Plumbs new SpdyFramerVisitorInterface method handling through QUIC test utilities, including the te…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1901423003: Plumbs new SpdyFramerVisitorInterface method handling through QUIC test utilities, including the te… (Closed)

Created:
4 years, 8 months ago by alyssar1

Modified:
4 years, 8 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@119562680

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Plumbs new SpdyFramerVisitorInterface method handling through QUIC test utilities, including the test client and test server. Preparation for CL 103292114. Additional changes, cleaning up tests from cr/119551887 and cr/119778209 Merge internal change: 119568788 R=rch@chromium.org BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+215 lines, -212 lines)			Patch
M	net/net.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_chromium_alarm_factory_test.cc	View	8 chunks	+16 lines, -16 lines	1 comment	Download
M	net/quic/quic_client_session_base.h	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	net/quic/quic_client_session_base.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download
D	net/quic/quic_epoll_alarm_factory_test.cc	View	1 chunk	+0 lines, -127 lines	0 comments	Download
M	net/quic/quic_network_transaction_unittest.cc	View	1 chunk	+0 lines, -53 lines	0 comments	Download
M	net/quic/spdy_utils.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	net/quic/spdy_utils.cc	View	3 chunks	+67 lines, -11 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_simple_server_stream.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_simple_server_stream.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_spdy_client_stream.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_spdy_client_stream.cc	View	2 chunks	+46 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1895703003 Patch 1

Dependent Patchsets:

Issue 1901173003 Patch 1

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

4 years, 8 months ago (2016-04-20 18:44:58 UTC) #2

https://codereview.chromium.org/1901423003/diff/1/net/quic/quic_chromium_alar...
File net/quic/quic_chromium_alarm_factory_test.cc (right):

https://codereview.chromium.org/1901423003/diff/1/net/quic/quic_chromium_alar...
net/quic/quic_chromium_alarm_factory_test.cc:5: #include
"net/quic/quic_chromium_alarm_factory.h"
Is this supposed to be part of this CL?

Expand Messages | Collapse Messages