[debugger] Hide scopes that originate from desugaring.

[debugger] Hide scopes that originate from desugaring.

Some scopes are introduced by the parser for desugaring and do not
have any positions associated. The debugger should not make them
visible.

Also add some missing source positions.

R=kozyatinskiy@chromium.org, rossberg@chromium.org
BUG=chromium:604458
LOG=Y

Committed: https://crrev.com/672983830f36222d90748ff588831b6dae565c38
Cr-Commit-Position: refs/heads/master@{#35721}

[Yang, 2016-04-20 09:21:16]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 09:21:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901413002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901413002/1

[commit-bot: I haz the power, 2016-04-20 09:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 09:36:37]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Yang, 2016-04-20 13:35:13]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 13:35:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901413002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901413002/20001

[commit-bot: I haz the power, 2016-04-20 13:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 13:59:16]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-04-21 00:06:39]

All DevTools tests are passed, lgtm. Thanks!

[Yang, 2016-04-21 06:48:55]

yangguo@chromium.org changed reviewers:
+ adamk@chromium.org

[Yang, 2016-04-21 06:48:56]

Andreas or Adam, could you take a look at the src/ast and src/parsing changes?
Thanks.

[adamk, 2016-04-21 19:59:21]

Thanks for taking care of my TODOs!

https://codereview.chromium.org/1901413002/diff/20001/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1901413002/diff/20001/src/parsing/parser.cc#n...
src/parsing/parser.cc:4392: param_scope->set_is_hidden();
Should this scope really be hidden? Could you add a test that uses sloppy eval
to introduce a var as part of a default parameter initializer expression? E.g.,
code like:

(function(x = eval("var y = 5; y")) { return x })()

If you break inside the eval, it seems like you want to be able to see "y". 

I admit this is very much a corner case, though, so lgtm if you want to land a
test for this with a TODO (if I'm correct that marking this "hidden" will hide y
erroneously).

[Yang, 2016-04-22 07:27:50]

On 2016/04/21 19:59:21, adamk wrote:
> Thanks for taking care of my TODOs!
> 
> https://codereview.chromium.org/1901413002/diff/20001/src/parsing/parser.cc
> File src/parsing/parser.cc (right):
> 
>
https://codereview.chromium.org/1901413002/diff/20001/src/parsing/parser.cc#n...
> src/parsing/parser.cc:4392: param_scope->set_is_hidden();
> Should this scope really be hidden? Could you add a test that uses sloppy eval
> to introduce a var as part of a default parameter initializer expression?
E.g.,
> code like:
> 
> (function(x = eval("var y = 5; y")) { return x })()
> 
> If you break inside the eval, it seems like you want to be able to see "y". 
> 
> I admit this is very much a corner case, though, so lgtm if you want to land a
> test for this with a TODO (if I'm correct that marking this "hidden" will hide
y
> erroneously).

Thanks. I fixed this and added a test.

[Yang, 2016-04-22 07:39:31]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-22 07:39:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1901413002/#ps60001
(title: "improve test")

[commit-bot: I haz the power, 2016-04-22 07:39:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901413002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901413002/60001

[commit-bot: I haz the power, 2016-04-22 07:54:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 07:54:31]

Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/573)
  v8_mac_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Yang, 2016-04-22 09:50:20]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-04-22 09:50:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org, adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1901413002/#ps80001
(title: "fix crash")

[commit-bot: I haz the power, 2016-04-22 09:50:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901413002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901413002/80001

[commit-bot: I haz the power, 2016-04-22 10:46:47]

Committed patchset #5 (id:80001)

[adamk, 2016-04-22 17:31:23]

lgtm, thanks for the (admittedly ridiculous) test case.

[commit-bot: I haz the power, 2016-04-22 19:15:20]

Description was changed from

==========
[debugger] Hide scopes that originate from desugaring.

Some scopes are introduced by the parser for desugaring and do not
have any positions associated. The debugger should not make them
visible.

Also add some missing source positions.

R=kozyatinskiy@chromium.org, rossberg@chromium.org
BUG=chromium:604458
LOG=Y
==========

to

==========
[debugger] Hide scopes that originate from desugaring.

Some scopes are introduced by the parser for desugaring and do not
have any positions associated. The debugger should not make them
visible.

Also add some missing source positions.

R=kozyatinskiy@chromium.org, rossberg@chromium.org
BUG=chromium:604458
LOG=Y

Committed: https://crrev.com/672983830f36222d90748ff588831b6dae565c38
Cr-Commit-Position: refs/heads/master@{#35721}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:21]

Patchset 5 (id:??) landed as
https://crrev.com/672983830f36222d90748ff588831b6dae565c38
Cr-Commit-Position: refs/heads/master@{#35721}