Modifications to activity logging end to end tests. Reduces the number of window.open calls to make…

chrome/test/data/extensions/api_test/activity_log_private/README

 This directory contains tests for chrome extension activity logging.
 
 The tests use two chrome extensions:
   -test  : sends messages to the friend extension and listens for activity
            logged by the friend extension. Checks the activity has been logged
            correctly.
   -friend: recieves messages from the extension and runs a function based on
            the contents of the message.
 
 
 Adding a new test:
 
   In friend/reply.js:
-    (1) Add a function to call the chrome api calls you want to test.
-        NOTE: The function should clean up any changes it made (e.g. listeners
+    (1) Add a function to call the chrome api calls you want to test. If you need

[felt, 2013/07/10 21:44:28]

re-wrap please

[karenlees, 2013/07/10 23:55:46]

Done.

+        to use window.open please consider adding your code to
+        executeApiCallsOnTabUpdated or executeDOMChangesOnTabUpdated. Every
+        extra window.open call will slow down the tests by 3s and cause timeouts.
+    (2) Add the name of the new function to the function map (fnMap).
+
+    IMPORTANT NOTES for adding tests:
+      - The function should clean up any changes it made (e.g. listeners
         it added) before finishing. If they are not cleaned up then unexpected
         behavior can happen in test cases that run after this function.
-    (2) Add the name of the new function to the function map (fnMap).
+      - Calling window.open in can use up to 3 secs per call in the debug

[felt, 2013/07/10 21:44:28]

"in can use up" -- I think you a word :)

[karenlees, 2013/07/10 23:55:46]

Done.

+        builds. Making lots of window.open calls will therefore cause the tests
+        to timeout. If your test needs to use window.open please consider
+        adding it to one of the following existing functions:
+          - executeApiCallsOnTabUpdated
+          - executeDOMChangesOnTabUpdated

[felt, 2013/07/10 21:44:28]

You asked me to check for clarity -- overall, I think this is clear.

[karenlees, 2013/07/10 23:55:46]

Great. Thanks!

 
   In friend/options.html:
     (1) Add a button to allow the new function to be called in manual mode.
 
   You may need also to modify the manifest.json and other files in the
   friend extension directory.
 
   In test/test.js:
     (1) Add the test to the testcase array.
 
@@ skipping 18 matching lines @@
   > out/Debug/browser_tests --gtest_filter=ActivityLogApiTest.TriggerEvent
 
 
 Running in manual mode:
 
   (1) Start chrome with out/Debug/chrome
   (2) Navigate to chrome://extensions
   (3) Install the friend and test extensions from your chrome src folder
   (4) Click on the "options" link under the friend extension
   (5) You should see the options page the buttons to run the functions manually