Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1901343004: [Polymer] update third_party polymer (Closed)

Created:
4 years, 8 months ago by dschuyler
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, asanka, dbeam+watch-polymer_chromium.org, michaelpg+watch-polymer_chromium.org, jlklein+watch-closure_chromium.org, dcheng, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-downloads_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Polymer] update third_party polymer This CL updates the third party Polymer JavaScript library, with the addition of a patch for neon-animated pages. The patch change is shown in the chromium.patch file within this CL. It comes from https://github.com/PolymerElements/neon-animation/pull/149 BUG=600887 TBR=dzhioev@chromium.org NOPRESUBMIT=true ^ because crisper files are machine generated and do not obey the 80 character limit. Committed: https://crrev.com/617644937cf254786783bc59b975613ea7e274fa Cr-Commit-Position: refs/heads/master@{#389329}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sorting files #

Patch Set 3 : new pull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1159 lines, -567 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 2 55 chunks +292 lines, -108 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 2 7 chunks +201 lines, -193 lines 0 comments Download
M third_party/polymer/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-dropdown/iron-dropdown-extracted.js View 6 chunks +11 lines, -12 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list.html View 3 chunks +13 lines, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-list/iron-list-extracted.js View 30 chunks +221 lines, -62 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-location/bower.json View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-location/iron-location-extracted.js View 1 2 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/compiled_resources2.gyp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js View 3 chunks +23 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-backdrop.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-behavior-extracted.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-overlay-behavior/iron-overlay-manager-extracted.js View 10 chunks +27 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/cascaded-animation-extracted.js View 1 2 3 chunks +16 lines, -23 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/animations/slide-down-animation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/bower.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animatable-behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages.html View 1 2 2 chunks +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animated-pages-extracted.js View 1 2 1 chunk +9 lines, -7 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-behavior-extracted.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animation-runner-behavior-extracted.js View 1 2 3 chunks +4 lines, -11 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-animations.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/neon-animation/neon-shared-element-animation-behavior-extracted.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-dropdown-menu/paper-dropdown-menu-light-extracted.js View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/bower.json View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-behavior-extracted.js View 5 chunks +11 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-input/paper-input-container.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/bower.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/paper-item/paper-item-shared-styles.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/v1_0/components-chromium/polymer-externs/polymer.externs.js View 1 2 10 chunks +148 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components_summary.txt View 1 2 8 chunks +43 lines, -43 lines 0 comments Download
M third_party/web-animations-js/sources/.bower.json View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/web-animations-js/sources/History.md View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M third_party/web-animations-js/sources/README.md View 1 2 3 chunks +30 lines, -19 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations-next-lite.min.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations-next-lite.min.js.map View 1 chunk +1 line, -1 line 0 comments Download
M third_party/web-animations-js/sources/web-animations-next.min.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations-next.min.js.map View 1 chunk +1 line, -1 line 0 comments Download
M third_party/web-animations-js/sources/web-animations.min.js View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/web-animations-js/sources/web-animations.min.js.map View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (13 generated)
dschuyler
Testing done: - this fixes my issue with subpages expanding - this fixes the redraw ...
4 years, 8 months ago (2016-04-21 01:17:19 UTC) #2
Dan Beam
surely there must be some BUG= to put here? also, were did we find the ...
4 years, 8 months ago (2016-04-21 18:48:26 UTC) #3
dschuyler
On 2016/04/21 18:48:26, Dan Beam wrote: > surely there must be some BUG= to put ...
4 years, 8 months ago (2016-04-21 18:57:27 UTC) #6
Dan Beam
https://codereview.chromium.org/1901343004/diff/1/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp File third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp (right): https://codereview.chromium.org/1901343004/diff/1/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp#newcode14 third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp:14: }, can we fix the sorting issues before landing?
4 years, 8 months ago (2016-04-21 20:33:36 UTC) #7
dschuyler
On 2016/04/21 20:33:36, Dan Beam wrote: > https://codereview.chromium.org/1901343004/diff/1/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp > File > third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp > (right): > ...
4 years, 8 months ago (2016-04-21 23:09:00 UTC) #9
dschuyler
https://codereview.chromium.org/1901343004/diff/1/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp File third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp (right): https://codereview.chromium.org/1901343004/diff/1/third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp#newcode14 third_party/polymer/v1_0/components-chromium/iron-dropdown/compiled_resources2.gyp:14: }, On 2016/04/21 20:33:36, Dan Beam wrote: > can ...
4 years, 8 months ago (2016-04-21 23:09:09 UTC) #10
Dan Beam
lgtm i guess, but i'd prefer to just wait for the fix to be agreed ...
4 years, 8 months ago (2016-04-22 02:29:21 UTC) #12
michaelpg
On 2016/04/22 02:29:21, Dan Beam wrote: > lgtm i guess, but i'd prefer to just ...
4 years, 8 months ago (2016-04-22 18:48:47 UTC) #13
dschuyler
On 2016/04/22 18:48:47, michaelpg wrote: > On 2016/04/22 02:29:21, Dan Beam wrote: > > lgtm ...
4 years, 8 months ago (2016-04-22 19:30:54 UTC) #14
dschuyler
On 2016/04/22 19:30:54, dschuyler wrote: > On 2016/04/22 18:48:47, michaelpg wrote: > > On 2016/04/22 ...
4 years, 8 months ago (2016-04-22 19:31:57 UTC) #15
michaelpg
lgtm. I would TBR dzhioev@ since I don't know when he'll be in. I'll also ...
4 years, 8 months ago (2016-04-22 19:34:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901343004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901343004/60001
4 years, 8 months ago (2016-04-22 23:20:37 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/172347)
4 years, 8 months ago (2016-04-22 23:35:51 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901343004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901343004/60001
4 years, 8 months ago (2016-04-23 00:41:06 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 8 months ago (2016-04-23 00:42:42 UTC) #27
commit-bot: I haz the power
4 years, 8 months ago (2016-04-23 00:45:06 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/617644937cf254786783bc59b975613ea7e274fa
Cr-Commit-Position: refs/heads/master@{#389329}

Powered by Google App Engine
This is Rietveld 408576698