Chromium Code Reviews| Index: ios/web/web_state/web_state_impl.mm |
| diff --git a/ios/web/web_state/web_state_impl.mm b/ios/web/web_state/web_state_impl.mm |
| index 09ca232373b4bde6179cf9590e7373fc34ac1679..22e5f8b89f0a4c80c9172b87c80530966180405b 100644 |
| --- a/ios/web/web_state/web_state_impl.mm |
| +++ b/ios/web/web_state/web_state_impl.mm |
| @@ -33,6 +33,20 @@ |
| namespace web { |
| +/* static */ |
| +std::unique_ptr<WebState> WebState::Create(const CreateParams& params) { |
| + WebStateImpl* web_state(new WebStateImpl(params.browser_state)); |
|
rohitrao (ping after 24h)
2016/04/21 00:17:18
Is it worth wrapping this in a unique_ptr too?
Eugene But (OOO till 7-30)
2016/04/21 00:48:16
Done.
|
| + |
| + NSString* window_name = nil; |
| + NSString* opener_id = nil; |
| + BOOL opened_by_dom = NO; |
| + int opener_navigation_index = 0; |
| + web_state->GetNavigationManagerImpl().InitializeSession( |
| + window_name, opener_id, opened_by_dom, opener_navigation_index); |
| + |
| + return std::unique_ptr<WebState>(web_state); |
|
rohitrao (ping after 24h)
2016/04/21 00:17:18
And then using web_state.release() here?
Eugene But (OOO till 7-30)
2016/04/21 00:48:16
Done.
|
| +} |
| + |
| WebStateImpl::WebStateImpl(BrowserState* browser_state) |
| : delegate_(nullptr), |
| is_loading_(false), |