[ios] Do not use private web// API in ios_web_shell.

[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API that is modeled from
WebContents::Create. New API is used it in web shell
instead of directly allocating WebStateImpl object.

BUG=597997
Committed: https://crrev.com/526b5158f99e9fc3aaf05c442c9c2e26e2dea1cd
Cr-Commit-Position: refs/heads/master@{#388672}

[Eugene But (OOO till 7-30), 2016-04-20 05:41:52]

Description was changed from

==========
[ios] Do not use private web// API in ios_web_shell.

BUG=597997
==========

to

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API and used it in web shell.

BUG=597997
==========

[Eugene But (OOO till 7-30), 2016-04-20 05:42:52]

Description was changed from

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API and used it in web shell.

BUG=597997
==========

to

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API and used it in web shell.
Also cleaned up web shell from unnecessary code.

BUG=597997
==========

[Eugene But (OOO till 7-30), 2016-04-20 05:42:58]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 05:43:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901343002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901343002/20001

[Eugene But (OOO till 7-30), 2016-04-20 05:49:20]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 05:49:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901343002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901343002/40001

[Eugene But (OOO till 7-30), 2016-04-20 05:51:00]

Description was changed from

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API and used it in web shell.
Also cleaned up web shell from unnecessary code.

BUG=597997
==========

to

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API that is modeled from
WebContents::Create. New API is used it in web shell
instead of directly allocating WebStateImpl object.

BUG=597997
==========

[commit-bot: I haz the power, 2016-04-20 05:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 05:56:27]

Dry run: Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Eugene But (OOO till 7-30), 2016-04-20 16:27:11]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 16:27:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901343002/60001

[commit-bot: I haz the power, 2016-04-20 16:34:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 16:34:24]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Eugene But (OOO till 7-30), 2016-04-20 16:55:39]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org, rohitrao@chromium.org

[Eugene But (OOO till 7-30), 2016-04-20 16:55:40]

This is the final CL to remove the usage of private web API in web_shell.

[kkhorimoto, 2016-04-21 00:04:54]

lgtm

[rohitrao (ping after 24h), 2016-04-21 00:17:18]

Woot!

lgtm

https://codereview.chromium.org/1901343002/diff/60001/ios/web/shell/view_cont...
File ios/web/shell/view_controller.mm (right):

https://codereview.chromium.org/1901343002/diff/60001/ios/web/shell/view_cont...
ios/web/shell/view_controller.mm:114: web::WebState::CreateParams
web_state_create_params(_browserState);
webStateCreateParams?

https://codereview.chromium.org/1901343002/diff/60001/ios/web/web_state/web_s...
File ios/web/web_state/web_state_impl.mm (right):

https://codereview.chromium.org/1901343002/diff/60001/ios/web/web_state/web_s...
ios/web/web_state/web_state_impl.mm:38: WebStateImpl* web_state(new
WebStateImpl(params.browser_state));
Is it worth wrapping this in a unique_ptr too?

https://codereview.chromium.org/1901343002/diff/60001/ios/web/web_state/web_s...
ios/web/web_state/web_state_impl.mm:47: return
std::unique_ptr<WebState>(web_state);
And then using web_state.release() here?

[Eugene But (OOO till 7-30), 2016-04-21 00:48:16]

Thanks!

https://codereview.chromium.org/1901343002/diff/60001/ios/web/shell/view_cont...
File ios/web/shell/view_controller.mm (right):

https://codereview.chromium.org/1901343002/diff/60001/ios/web/shell/view_cont...
ios/web/shell/view_controller.mm:114: web::WebState::CreateParams
web_state_create_params(_browserState);
On 2016/04/21 00:17:18, rohitrao wrote:
> webStateCreateParams?

Done.

https://codereview.chromium.org/1901343002/diff/60001/ios/web/web_state/web_s...
File ios/web/web_state/web_state_impl.mm (right):

https://codereview.chromium.org/1901343002/diff/60001/ios/web/web_state/web_s...
ios/web/web_state/web_state_impl.mm:38: WebStateImpl* web_state(new
WebStateImpl(params.browser_state));
On 2016/04/21 00:17:18, rohitrao wrote:
> Is it worth wrapping this in a unique_ptr too?

Done.

https://codereview.chromium.org/1901343002/diff/60001/ios/web/web_state/web_s...
ios/web/web_state/web_state_impl.mm:47: return
std::unique_ptr<WebState>(web_state);
On 2016/04/21 00:17:18, rohitrao wrote:
> And then using web_state.release() here?

Done.

[Eugene But (OOO till 7-30), 2016-04-21 00:49:40]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-04-21 00:49:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org, rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/1901343002/#ps80001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2016-04-21 00:50:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901343002/80001

[commit-bot: I haz the power, 2016-04-21 03:06:25]

Description was changed from

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API that is modeled from
WebContents::Create. New API is used it in web shell
instead of directly allocating WebStateImpl object.

BUG=597997
==========

to

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API that is modeled from
WebContents::Create. New API is used it in web shell
instead of directly allocating WebStateImpl object.

BUG=597997
==========

[commit-bot: I haz the power, 2016-04-21 03:06:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:30:46]

Description was changed from

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API that is modeled from
WebContents::Create. New API is used it in web shell
instead of directly allocating WebStateImpl object.

BUG=597997
==========

to

==========
[ios] Do not use private web// API in ios_web_shell.

Added WebState::Create API that is modeled from
WebContents::Create. New API is used it in web shell
instead of directly allocating WebStateImpl object.

BUG=597997

Committed: https://crrev.com/526b5158f99e9fc3aaf05c442c9c2e26e2dea1cd
Cr-Commit-Position: refs/heads/master@{#388672}
==========

[commit-bot: I haz the power, 2016-04-22 19:30:47]

Patchset 5 (id:??) landed as
https://crrev.com/526b5158f99e9fc3aaf05c442c9c2e26e2dea1cd
Cr-Commit-Position: refs/heads/master@{#388672}