components/page_load_metrics/renderer/page_timing_metrics_sender.h - Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/renderer/page_timing_metrics_sender.h

Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bmcquade@ review, cleanup Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/page_load_metrics/renderer/metrics_render_frame_observer_unittest.cc ('k') | components/page_load_metrics/renderer/page_timing_metrics_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/renderer/page_timing_metrics_sender.h

diff --git a/components/page_load_metrics/renderer/page_timing_metrics_sender.h b/components/page_load_metrics/renderer/page_timing_metrics_sender.h

index 37d16fbc9881984f97f19c0e1b602aa415e48fa3..1cdfb735be0af9829118f1bed6656926a9fc2d34 100644

--- a/components/page_load_metrics/renderer/page_timing_metrics_sender.h

+++ b/components/page_load_metrics/renderer/page_timing_metrics_sender.h

@@ -28,7 +28,8 @@ class PageTimingMetricsSender {

public:

PageTimingMetricsSender(IPC::Sender* ipc_sender,

int routing_id,

- std::unique_ptr<base::Timer> timer);

+ std::unique_ptr<base::Timer> timer,

+ const PageLoadTiming& initial_timing);

~PageTimingMetricsSender();

void DidObserveLoadingBehavior(blink::WebLoadingBehaviorFlag behavior);

@@ -38,7 +39,7 @@ class PageTimingMetricsSender {

base::Timer* timer() const { return timer_.get(); }

private:

- void EnsureSendTimer();

+ void EnsureSendTimer(int delay);

void SendNow();

IPC::Sender* const ipc_sender_;