tools/metrics/histograms/histograms.xml - Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaks Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« components/page_load_metrics/renderer/page_timing_metrics_sender.cc ('K') | « components/page_load_metrics/renderer/page_timing_metrics_sender_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 634a6556291ff0a372f6f5bbffcd2225050791c4..2bbf269ad7d554a266eec7b7116d286c8f04a07e 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -91554,6 +91554,31 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="PageLoad.Timing2.NavigationToFirstBackground"/>

</histogram_suffixes>

+<histogram_suffixes name="PageLoadMetricsAbortClients" separator="."

+ ordering="prefix">

+ <suffix name="Clients.FromGWS2"

+ label="PageLoadMetrics that are a result of a navigation from a Google

+ web search"/>

+ <suffix name="Clients.FromGWS2.Opener"

+ label="PageLoadMetrics that are a result of a navigation from a Google

+ web search, where the search result is in a new tab that did not

+ use the Javascript redictor url."/>

+ <affected-histogram

+ name="PageLoad.AbortTiming.Close.AfterCommit.BeforePaint"/>

+ <affected-histogram name="PageLoad.AbortTiming.Close.BeforeCommit"/>

+ <affected-histogram

+ name="PageLoad.AbortTiming.ForwardBackNavigation.AfterCommit.BeforePaint"/>

+ <affected-histogram

+ name="PageLoad.AbortTiming.NewNavigation.AfterCommit.BeforePaint"/>

+ <affected-histogram name="PageLoad.AbortTiming.Other.BeforeCommit"/>

+ <affected-histogram

+ name="PageLoad.AbortTiming.Reload.AfterCommit.BeforePaint"/>

+ <affected-histogram name="PageLoad.AbortTiming.Stop.AfterCommit.BeforePaint"/>

+ <affected-histogram name="PageLoad.AbortTiming.Stop.BeforeCommit"/>

+ <affected-histogram

+ name="PageLoad.AbortTiming.UnknownNavigation.BeforeCommit"/>

+</histogram_suffixes>

<histogram_suffixes name="PageLoadMetricsClients" separator="."

ordering="prefix">

<suffix name="Clients.FromGWS"

@@ -91566,6 +91591,9 @@ To add a new entry, add it with any value and run test to compute valid value.

<suffix name="Clients.FromGWS2"

label="PageLoadMetrics that are a result of a navigation from a Google

web search"/>

+ <suffix name="Clients.FromGWS2.Opener"

+ label="PageLoadMetrics that are a result of a navigation from a Google

+ web search, where the search result is opened in a new tab"/>

<suffix name="Clients.DocWrite.Evaluator"

label="PageLoadMetrics from a page that could have been evaluated by

the DocumentWriteEvaluator"/>