Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: components/page_load_metrics/renderer/page_timing_metrics_sender.cc

Issue 1901303004: [ Don't commit ] Add FromGWS variants to the AbortTiming metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bmcquade@ review, cleanup Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/renderer/page_timing_metrics_sender.h" 5 #include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
11 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
12 #include "components/page_load_metrics/common/page_load_metrics_messages.h" 12 #include "components/page_load_metrics/common/page_load_metrics_messages.h"
13 #include "ipc/ipc_sender.h" 13 #include "ipc/ipc_sender.h"
14 14
15 namespace page_load_metrics { 15 namespace page_load_metrics {
16 16
17 namespace { 17 namespace {
18 const int kInitialTimerDelayMillis = 50;
18 const int kTimerDelayMillis = 1000; 19 const int kTimerDelayMillis = 1000;
19 } // namespace 20 } // namespace
20 21
21 PageTimingMetricsSender::PageTimingMetricsSender( 22 PageTimingMetricsSender::PageTimingMetricsSender(
22 IPC::Sender* ipc_sender, 23 IPC::Sender* ipc_sender,
23 int routing_id, 24 int routing_id,
24 std::unique_ptr<base::Timer> timer) 25 std::unique_ptr<base::Timer> timer,
26 const PageLoadTiming& initial_timing)
25 : ipc_sender_(ipc_sender), 27 : ipc_sender_(ipc_sender),
26 routing_id_(routing_id), 28 routing_id_(routing_id),
27 timer_(std::move(timer)), 29 timer_(std::move(timer)),
28 metadata_(PageLoadMetadata()) {} 30 last_timing_(initial_timing),
31 metadata_(PageLoadMetadata()) {
32 // Send an initial IPC relatively early to help track aborts.
33 EnsureSendTimer(kInitialTimerDelayMillis);
34 }
29 35
30 // On destruction, we want to send any data we have if we have a timer 36 // On destruction, we want to send any data we have if we have a timer
31 // currently running (and thus are talking to a browser process) 37 // currently running (and thus are talking to a browser process)
32 PageTimingMetricsSender::~PageTimingMetricsSender() { 38 PageTimingMetricsSender::~PageTimingMetricsSender() {
33 if (timer_->IsRunning()) { 39 if (timer_->IsRunning()) {
34 timer_->Stop(); 40 timer_->Stop();
35 SendNow(); 41 SendNow();
36 } 42 }
37 } 43 }
38 44
39 void PageTimingMetricsSender::DidObserveLoadingBehavior( 45 void PageTimingMetricsSender::DidObserveLoadingBehavior(
40 blink::WebLoadingBehaviorFlag behavior) { 46 blink::WebLoadingBehaviorFlag behavior) {
41 if (behavior & metadata_.behavior_flags) 47 if (behavior & metadata_.behavior_flags)
42 return; 48 return;
43 metadata_.behavior_flags |= behavior; 49 metadata_.behavior_flags |= behavior;
44 EnsureSendTimer(); 50 EnsureSendTimer(kTimerDelayMillis);
45 } 51 }
46 52
47 void PageTimingMetricsSender::Send(const PageLoadTiming& timing) { 53 void PageTimingMetricsSender::Send(const PageLoadTiming& timing) {
48 if (timing == last_timing_) 54 if (timing == last_timing_)
49 return; 55 return;
50 56
51 // We want to make sure that each PageTimingMetricsSender is associated 57 // We want to make sure that each PageTimingMetricsSender is associated
52 // with a distinct page navigation. Because we reset the object on commit, 58 // with a distinct page navigation. Because we reset the object on commit,
53 // we can trash last_timing_ on a provisional load before SendNow() fires. 59 // we can trash last_timing_ on a provisional load before SendNow() fires.
54 if (!last_timing_.navigation_start.is_null() && 60 if (!last_timing_.navigation_start.is_null() &&
55 last_timing_.navigation_start != timing.navigation_start) { 61 last_timing_.navigation_start != timing.navigation_start) {
56 return; 62 return;
57 } 63 }
58 64
59 last_timing_ = timing; 65 last_timing_ = timing;
60 EnsureSendTimer(); 66 EnsureSendTimer(kTimerDelayMillis);
61 } 67 }
62 68
63 void PageTimingMetricsSender::EnsureSendTimer() { 69 void PageTimingMetricsSender::EnsureSendTimer(int delay) {
64 if (!timer_->IsRunning()) 70 if (!timer_->IsRunning())
65 timer_->Start( 71 timer_->Start(
66 FROM_HERE, base::TimeDelta::FromMilliseconds(kTimerDelayMillis), 72 FROM_HERE, base::TimeDelta::FromMilliseconds(delay),
67 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 73 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
68 } 74 }
69 75
70 void PageTimingMetricsSender::SendNow() { 76 void PageTimingMetricsSender::SendNow() {
71 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated( 77 ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
72 routing_id_, last_timing_, metadata_)); 78 routing_id_, last_timing_, metadata_));
73 } 79 }
74 80
75 } // namespace page_load_metrics 81 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698