Issue 19013004: fix bug with awesome filtered images sometimes being slightly offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19013004: fix bug with awesome filtered images sometimes being slightly offset. (Closed)

Created:
7 years, 5 months ago by humper

Modified:
7 years, 5 months ago

Reviewers:
ernstm1, senorblanco, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix bug with awesome filtered images sometimes being slightly offset. BUG= Committed: https://code.google.com/p/skia/source/detail?r=9980

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -23 lines)			Patch
	M	src/core/SkBitmapFilter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/core/SkBitmapFilter.cpp	View		8 chunks	+22 lines, -22 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

humper

Found the source of some spurious image shifts; this fix also makes the other filter ...

7 years, 5 months ago (2013-07-10 19:27:48 UTC) #1

reed1

https://codereview.chromium.org/19013004/diff/1/src/core/SkBitmapFilter.cpp File src/core/SkBitmapFilter.cpp (right): https://codereview.chromium.org/19013004/diff/1/src/core/SkBitmapFilter.cpp#newcode99 src/core/SkBitmapFilter.cpp:99: int x0 = SkClampMax(int(ceil(SkScalarToFloat(srcPt.fX)-s.getBitmapFilter()->width())), maxX); sk_float_ceil2int sk_float_floor2int These guys ...

7 years, 5 months ago (2013-07-10 20:56:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r9980.

Expand Messages | Collapse Messages