ui/accelerated_widget_mac/DEPS - Issue 1901253002: Mac: Towards moving CALayerTree to the browser proc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/accelerated_widget_mac/DEPS

Issue 1901253002: Mac: Towards moving CALayerTree to the browser proc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+gpu/GLES2",
	no sievers 2016/04/20 00:20:14 That dependency seems backwards. Can you add the m That dependency seems backwards. Can you add the macros in ui/gl/gl_bindings.h and then include that from ca_layer_tree_mac.mm? ccameron 2016/04/20 07:17:15 Are you sure? This is used to define GL_CA_LAYER_E Show quoted text On 2016/04/20 00:20:14, sievers wrote: > That dependency seems backwards. Can you add the macros in ui/gl/gl_bindings.h > and then include that from ca_layer_tree_mac.mm? Are you sure? This is used to define GL_CA_LAYER_EDGE_RIGHT_CHROMIUM, which is then used in cc/output/ca_layer_overlay.cc. That's where things get disastrous. Because ui/ tends to include the <GL/gl.h>, while cc/ tends to include "third_party/khronos/GLES2/gl2ext.h". Trying to get ui/gl_bindings.h into cc/ seems to have been repeatedly attempted and failed -- see crbug.com/512833. After several hours fighting with this, I give up. Two options 1. Leave things as they are. Once the move to the browser process is complete, we can just remove the GLES2 dependency, since we no longer need to go through the command buffer. 2. Create a ui/gl/gl_bindings_chromium.h, which #defines all of the _CHROMIUM values, and doesn't include any of the system headers. That file could then be included without fear of conflicts. Which would you prefer?
2 "+third_party/skia",	3 "+third_party/skia",

3 "+ui/base/cocoa",	4 "+ui/base/cocoa",

4 "+ui/base",	5 "+ui/base",

5 "+ui/events",	6 "+ui/events",

	7 "+ui/gfx",

6 "+ui/gfx/geometry",	8 "+ui/gfx/geometry",

	9 "+ui/gfx/mac",

7 "+ui/gfx/native_widget_types.h",	10 "+ui/gfx/native_widget_types.h",

8 "+ui/gl",	11 "+ui/gl",

9 ]	12 ]

OLD	NEW

« no previous file with comments | « ui/accelerated_widget_mac/BUILD.gn ('k') | ui/accelerated_widget_mac/accelerated_widget_mac.gyp » ('j') | no next file with comments »