Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901203002: Don't calculate overflow on tables that need layout (Closed)

Created:
4 years, 8 months ago by rhogan
Modified:
4 years, 8 months ago
Reviewers:
Xianzhu, eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@604095-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't calculate overflow on tables that need layout BUG=604664 Committed: https://crrev.com/dd58ba2e0a29385319e2b1fd351a77b04886b591 Cr-Commit-Position: refs/heads/master@{#388273}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/overflow/do-not-calc-overflow-on-tables-needing-layout.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/overflow/do-not-calc-overflow-on-tables-needing-layout-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1868013002 Patch 80001

Messages

Total messages: 9 (3 generated)
rhogan
4 years, 8 months ago (2016-04-19 18:05:47 UTC) #2
Xianzhu
lgtm
4 years, 8 months ago (2016-04-19 18:07:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901203002/1
4 years, 8 months ago (2016-04-19 18:14:52 UTC) #5
eae
LGTM
4 years, 8 months ago (2016-04-19 18:18:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 19:26:12 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:55 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dd58ba2e0a29385319e2b1fd351a77b04886b591
Cr-Commit-Position: refs/heads/master@{#388273}

Powered by Google App Engine
This is Rietveld 408576698