Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901163002: Don't allow events to be swallowed by MdFocusRing. (Closed)

Created:
4 years, 8 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow events to be swallowed by MdFocusRing. BUG=604344 Committed: https://crrev.com/6adf4a134edc444c3634d215380325846dad8011 Cr-Commit-Position: refs/heads/master@{#388323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/views/controls/button/custom_button.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Evan Stade
Although I tried several ways of generating events to unit test this fix, I couldn't ...
4 years, 8 months ago (2016-04-19 16:54:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901163002/1
4 years, 8 months ago (2016-04-19 16:54:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 17:39:32 UTC) #6
sky
LGTM
4 years, 8 months ago (2016-04-19 19:09:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901163002/1
4 years, 8 months ago (2016-04-19 21:41:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 21:50:19 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:16:53 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6adf4a134edc444c3634d215380325846dad8011
Cr-Commit-Position: refs/heads/master@{#388323}

Powered by Google App Engine
This is Rietveld 408576698