third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-no-intrinsic-size.html - Issue 1901153002: Implement createImageBitmap(SVG) of intrinsic size = 0

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-createImageBitmap-svg-no-intrinsic-size.html

Issue 1901153002: Implement createImageBitmap(SVG) of intrinsic size = 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../resources/js-test.js"></script>	4 <script src="../../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8	8

9 description("Test createImageBitmap from a SVG image without intrinsic size.");	9 description("Test createImageBitmap from a SVG image without intrinsic size.");

10 window.jsTestIsAsync = true;	10 window.jsTestIsAsync = true;

11	11

12 var image = new Image();	12 var image1Loaded = false;

13 image.onload = function() {	13 var image2Loaded = false;

14 createImageBitmap(image).then(function(imageBitmap) {	14 var image1 = new Image();

15 testFailed("createImageBitmap promise resolved, expected to be rejected" );	15 var image2 = new Image();

	16 /*image1.onload = function() {

	17 image1Loaded = true;

	18 testCreateImageBitmap();

	19 }

	20 image1.src = '../../svg/hixie/intrinsic/resources/003.svg';

	21 */

	22 image2.onload = function() {

	23 console.log("image2 loaded");
	xidachen 2016/04/19 16:52:03 The test doesn't even get to this point. The test doesn't even get to this point. davve 2016/04/19 19:31:47 Oh, right. Such an image probably has Image::isNul Show quoted text On 2016/04/19 16:52:03, xidachen wrote: > The test doesn't even get to this point. Oh, right. Such an image probably has Image::isNull() returning true, causing the loading code somewhere to drop it, IIRC. davve 2016/04/21 09:50:48 If you see value in getting around this issue, cha Show quoted text On 2016/04/19 19:31:47, David Vest wrote: > On 2016/04/19 16:52:03, xidachen wrote: > > The test doesn't even get to this point. > > Oh, right. Such an image probably has Image::isNull() returning true, causing > the loading code somewhere to drop it, IIRC. If you see value in getting around this issue, change your zeroSize.svg to look something like this: <svg xmlns="http://www.w3.org/2000/svg"> <script> onload = function() { document.documentElement.setAttribute('width', '0'); document.documentElement.setAttribute('height', '0'); } </script> </svg> I uncommented the rest of your changes and it seemed to work fine. If you like, the test could use some general love too. (<!DOCTYPE html> and remove unnecessary <html>, <head>, <body> tags comes to mind)
	24 image2Loaded = true;

	25 testCreateImageBitmap();

	26 }

	27 image2.src = 'resources/zeroSize.svg';

	28

	29 function testCreateImageBitmap()

	30 {

	31 if (image2Loaded) {

	32 //if (image1Loaded && image2Loaded) {

16 finishJSTest();	33 finishJSTest();

17 }, function (e) {	34 /*createImageBitmap(image1).then(function(imageBitmap) {

18 testPassed("createImageBitmap promise rejected: " + e);	35 testFailed("createImageBitmap promise resolved, expected to be rejec ted");

19 finishJSTest();	36 finishJSTest();

20 });	37 }, function (e) {

	38 testPassed("createImageBitmap promise rejected: " + e);

	39 finishJSTest();

	40 });*/

	41 }

21 }	42 }

22 image.src = '../../svg/hixie/intrinsic/resources/003.svg';

23

24 </script>	43 </script>

25 </body>	44 </body>

26 </html>	45 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/canvas/resources/zeroSize.svg » ('j') | no next file with comments »