Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1901113002: Move DM png code to picture_utils, for use by other tools. (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move DM png code to picture_utils, for use by other tools. Planning to re-use this code in skiaserve in an upcoming change. TBR=mtklein@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1901113002 Committed: https://skia.googlesource.com/skia/+/3c579dcff81dab48a5fb3801d7a34f9c00256ec4

Patch Set 1 #

Patch Set 2 : Fix compile errors. Add error checking. #

Patch Set 3 : Move to picture_utils. Better fit, fewer dependencies when adding to skiaserve #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -66 lines) Patch
M dm/DM.cpp View 1 2 4 chunks +7 lines, -65 lines 0 comments Download
M gyp/dm.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/picture_utils.h View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M tools/picture_utils.cpp View 1 2 2 chunks +74 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Brian Osman
4 years, 8 months ago (2016-04-19 14:46:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901113002/1
4 years, 8 months ago (2016-04-19 14:46:55 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/2033)
4 years, 8 months ago (2016-04-19 14:48:06 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901113002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901113002/20001
4 years, 8 months ago (2016-04-19 14:55:38 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 15:05:18 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901113002/40001
4 years, 8 months ago (2016-04-19 15:49:56 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-19 16:01:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901113002/40001
4 years, 8 months ago (2016-04-19 16:17:16 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/3c579dcff81dab48a5fb3801d7a34f9c00256ec4
4 years, 8 months ago (2016-04-19 16:18:14 UTC) #21
mtklein
4 years, 8 months ago (2016-04-19 17:28:46 UTC) #22
Message was sent while issue was closed. 
Man, that picture_utils.h really is a dumping ground for odd little utility
functions.  Doesn't really have anything to do with SkPicture...  but as such,
it seems like the perfect place for this new odd little utility function that
has nothing to do with SkPicture.

lgtm

Powered by Google App Engine
This is Rietveld 408576698