V8: Show build environment in failure logs

V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300108

[Michael Achenbach, 2016-04-20 14:50:36]

Description was changed from

==========
V8: Show build environment in failure logs.

BUG=
==========

to

==========
V8: Show build environment in failure logs.

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.
==========

[Michael Achenbach, 2016-04-20 14:50:37]

machenbach@chromium.org changed reviewers:
+ kjellander@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2016-04-20 14:51:42]

Description was changed from

==========
V8: Show build environment in failure logs.

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.
==========

to

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.
==========

[Michael Achenbach, 2016-04-20 14:52:01]

PTAL

[Michael Achenbach, 2016-04-20 14:53:23]

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipes/v8.ex...
File
scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json
(right):

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipes/v8.ex...
scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json:639:
"@@@STEP_LOG_LINE@slow@@@@",
FYI: On this bot we can see some real data and not the simulated test data, as
the bot is a builder_tester.

[Michael Achenbach, 2016-04-20 14:53:31]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 14:53:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901103004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901103004/1

[commit-bot: I haz the power, 2016-04-20 14:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 14:57:06]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-04-20 14:58:24]

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/v8/api.py (right):

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/api.py:717: for i in sorted(build_environment):
nit: s/i/k[ey]

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/api.py:971: properties['build_environment'] =
self.build_environment
can it potentially be so large so as not fitting into max property length? I've
hit it with try_recipe - i think it's VARCHAR(1023) :)

[tandrii(chromium), 2016-04-20 15:01:19]

LGTM

[Michael Achenbach, 2016-04-20 15:05:08]

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/v8/api.py (right):

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/api.py:971: properties['build_environment'] =
self.build_environment
On 2016/04/20 14:58:23, tandrii(chromium) wrote:
> can it potentially be so large so as not fitting into max property length?
I've
> hit it with try_recipe - i think it's VARCHAR(1023) :)

I'll add a check. And I should also add a check that on tester bots, we only
make use of the data provided through a property as the one calculated from the
config is most likely wrong.

[Michael Achenbach, 2016-04-21 14:39:57]

Description was changed from

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.
==========

to

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516
==========

[Michael Achenbach, 2016-04-21 14:41:33]

Patch 2 adds some checks, then some rebase, patch 5 adds a test that covers the
lines.

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/v8/api.py (right):

https://codereview.chromium.org/1901103004/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/v8/api.py:717: for i in sorted(build_environment):
On 2016/04/20 14:58:24, tandrii(chromium) wrote:
> nit: s/i/k[ey]

Done.

[Michael Achenbach, 2016-04-21 14:43:59]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-04-21 14:43:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1901103004/#ps80001
(title: "Add test")

[commit-bot: I haz the power, 2016-04-21 14:44:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901103004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901103004/80001

[commit-bot: I haz the power, 2016-04-21 14:48:06]

Description was changed from

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516
==========

to

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080
==========

[commit-bot: I haz the power, 2016-04-21 14:48:07]

Committed patchset #5 (id:80001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300080

[Michael Achenbach, 2016-04-22 07:20:11]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1906353002/ by machenbach@chromium.org.

The reason for reverting is: Might break the CQ: http://crbug.com/605846.

[Michael Achenbach, 2016-04-22 08:00:20]

Description was changed from

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080
==========

to

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080
==========

[Michael Achenbach, 2016-04-22 08:11:11]

PTAL at patch 6. This fixes the problem detected in http://crbug.com/605846.

[tandrii(chromium), 2016-04-22 10:41:10]

LGTM!

[Michael Achenbach, 2016-04-22 10:41:33]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-04-22 10:41:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901103004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901103004/100001

[commit-bot: I haz the power, 2016-04-22 10:46:04]

Description was changed from

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080
==========

to

==========
V8: Show build environment in failure logs

This will make it easier for developers to reproduce
failures.

Currently, the indirection between builders/testers and
between swarming trigger/collect makes it hard to
reason how the test executables were built.

BUG=605516

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300080

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300108
==========

[commit-bot: I haz the power, 2016-04-22 10:46:05]

Committed patchset #6 (id:100001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300108