Compensate for source scaling in hidpi mode

Compensate for source scaling in hidpi mode

In crrev.com/379801 scaling of hidpi nine piece image grids was
changed from using the real image size to using the "layout'ed" image
size (i.e. image size compensated by image scale factor) since that is
what Image::imageSize() returns. Instead the computed source rect was
scaled afterwards, right before drawing.

If GraphicsContext.drawTiledImage() is called with (stretch, stretch)
as tile rules, it ignores the passed scale factor and computes the
scale factor between source and destination itself. However, if one
rule is stretch and the other one repeat, or if both are repeat, the
tile scale factor is used when drawing and the relation between the
sizes of source and dest ignored.

What was missing from crrev.com/379801 was to compensate for the image
scale factor by adjusting tileScale. That meant that the (stretch,
stretch) worked fine but as soon as one repeat was specified, the
scale factor was wrong.

BUG=601544
Committed: https://crrev.com/ecead9a073907d4a2ba8b98527c9cb22125d6fa8
Cr-Commit-Position: refs/heads/master@{#388451}

[davve, 2016-04-19 14:45:12]

davve@opera.com changed reviewers:
+ fs@opera.com

[davve, 2016-04-19 14:45:13]

PTAL. The core of the change is:

drawInfo.tileScale.scale(1 / imageScaleFactor);

The rest is just moving around and updating tests.

[davve, 2016-04-19 14:47:38]

Description was changed from

==========
Compensate for source scaling in hidpi mode

In crrev.com/379801 scaling of hidpi nine piece image grids was
changed from using the real image size to using the "layout'ed" image
size (i.e. image size compensated by image scale factor) since that is
what Image::imageSize() returns. Intstead the computed source rect was
scaled afterwards, right before drawing.

If GraphicsContext.drawTiledImage() is called with (stretch, stretch)
as tile rules, it ignores the passed scale factor and computes the
scale factor between source and destination itself. However, if one
rule is stretch and the other one repeat, or if both are repeat, the
tile scale factor is used when drawing and the relation between the
sizes of source and dest ignored.

What was missing from crrev.com/379801 was to compensate for the image
scale factor by adjusting tileScale. That meant that the (stretch,
stretch) worked fine but as soon as one repeat was specified, the
scale factor was wrong.

BUG=601544
==========

to

==========
Compensate for source scaling in hidpi mode

In crrev.com/379801 scaling of hidpi nine piece image grids was
changed from using the real image size to using the "layout'ed" image
size (i.e. image size compensated by image scale factor) since that is
what Image::imageSize() returns. Instead the computed source rect was
scaled afterwards, right before drawing.

If GraphicsContext.drawTiledImage() is called with (stretch, stretch)
as tile rules, it ignores the passed scale factor and computes the
scale factor between source and destination itself. However, if one
rule is stretch and the other one repeat, or if both are repeat, the
tile scale factor is used when drawing and the relation between the
sizes of source and dest ignored.

What was missing from crrev.com/379801 was to compensate for the image
scale factor by adjusting tileScale. That meant that the (stretch,
stretch) worked fine but as soon as one repeat was specified, the
scale factor was wrong.

BUG=601544
==========

[davve, 2016-04-19 14:48:19]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 14:48:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901103002/1

[fs, 2016-04-19 14:48:40]

Description was changed from

==========
Compensate for source scaling in hidpi mode

In crrev.com/379801 scaling of hidpi nine piece image grids was
changed from using the real image size to using the "layout'ed" image
size (i.e. image size compensated by image scale factor) since that is
what Image::imageSize() returns. Instead the computed source rect was
scaled afterwards, right before drawing.

If GraphicsContext.drawTiledImage() is called with (stretch, stretch)
as tile rules, it ignores the passed scale factor and computes the
scale factor between source and destination itself. However, if one
rule is stretch and the other one repeat, or if both are repeat, the
tile scale factor is used when drawing and the relation between the
sizes of source and dest ignored.

What was missing from crrev.com/379801 was to compensate for the image
scale factor by adjusting tileScale. That meant that the (stretch,
stretch) worked fine but as soon as one repeat was specified, the
scale factor was wrong.

BUG=601544
==========

to

==========
Compensate for source scaling in hidpi mode

In crrev.com/379801 scaling of hidpi nine piece image grids was
changed from using the real image size to using the "layout'ed" image
size (i.e. image size compensated by image scale factor) since that is
what Image::imageSize() returns. Instead the computed source rect was
scaled afterwards, right before drawing.

If GraphicsContext.drawTiledImage() is called with (stretch, stretch)
as tile rules, it ignores the passed scale factor and computes the
scale factor between source and destination itself. However, if one
rule is stretch and the other one repeat, or if both are repeat, the
tile scale factor is used when drawing and the relation between the
sizes of source and dest ignored.

What was missing from crrev.com/379801 was to compensate for the image
scale factor by adjusting tileScale. That meant that the (stretch,
stretch) worked fine but as soon as one repeat was specified, the
scale factor was wrong.

BUG=601544
==========

[fs, 2016-04-19 14:59:34]

lgtm

https://codereview.chromium.org/1901103002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-button-expected.html
(right):

https://codereview.chromium.org/1901103002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-button-expected.html:1:
<script src="resources/srcset-helper.js"></script>
Ditto.

https://codereview.chromium.org/1901103002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-button.html
(right):

https://codereview.chromium.org/1901103002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-button.html:1:
<title>border-image with border-image-repeat in hidpi setting</title>
Nit: Doctype? (I'm guessing this doesn't need quirks-mode?)

[commit-bot: I haz the power, 2016-04-19 16:05:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 16:05:51]

Dry run: This issue passed the CQ dry run.

[davve, 2016-04-20 07:37:18]

The CQ bit was checked by davve@opera.com

[davve, 2016-04-20 07:37:18]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1901103002/#ps20001
(title: "Add DOCTYPE to added test.")

[commit-bot: I haz the power, 2016-04-20 07:37:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1901103002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1901103002/20001

[davve, 2016-04-20 07:40:19]

https://codereview.chromium.org/1901103002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-button.html
(right):

https://codereview.chromium.org/1901103002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-button.html:1:
<title>border-image with border-image-repeat in hidpi setting</title>
On 2016/04/19 14:59:34, fs wrote:
> Nit: Doctype? (I'm guessing this doesn't need quirks-mode?)

Doh!

I copied another test in the directory to start from and didn't notice. Will
file another CL to add DOCTYPE to tests in this subdir for some sense of
consistency (and perhaps help future selves from making this error).

[commit-bot: I haz the power, 2016-04-20 09:06:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:21:50]

Description was changed from

==========
Compensate for source scaling in hidpi mode

In crrev.com/379801 scaling of hidpi nine piece image grids was
changed from using the real image size to using the "layout'ed" image
size (i.e. image size compensated by image scale factor) since that is
what Image::imageSize() returns. Instead the computed source rect was
scaled afterwards, right before drawing.

If GraphicsContext.drawTiledImage() is called with (stretch, stretch)
as tile rules, it ignores the passed scale factor and computes the
scale factor between source and destination itself. However, if one
rule is stretch and the other one repeat, or if both are repeat, the
tile scale factor is used when drawing and the relation between the
sizes of source and dest ignored.

What was missing from crrev.com/379801 was to compensate for the image
scale factor by adjusting tileScale. That meant that the (stretch,
stretch) worked fine but as soon as one repeat was specified, the
scale factor was wrong.

BUG=601544
==========

to

==========
Compensate for source scaling in hidpi mode

In crrev.com/379801 scaling of hidpi nine piece image grids was
changed from using the real image size to using the "layout'ed" image
size (i.e. image size compensated by image scale factor) since that is
what Image::imageSize() returns. Instead the computed source rect was
scaled afterwards, right before drawing.

If GraphicsContext.drawTiledImage() is called with (stretch, stretch)
as tile rules, it ignores the passed scale factor and computes the
scale factor between source and destination itself. However, if one
rule is stretch and the other one repeat, or if both are repeat, the
tile scale factor is used when drawing and the relation between the
sizes of source and dest ignored.

What was missing from crrev.com/379801 was to compensate for the image
scale factor by adjusting tileScale. That meant that the (stretch,
stretch) worked fine but as soon as one repeat was specified, the
scale factor was wrong.

BUG=601544

Committed: https://crrev.com/ecead9a073907d4a2ba8b98527c9cb22125d6fa8
Cr-Commit-Position: refs/heads/master@{#388451}
==========

[commit-bot: I haz the power, 2016-04-22 19:21:51]

Patchset 2 (id:??) landed as
https://crrev.com/ecead9a073907d4a2ba8b98527c9cb22125d6fa8
Cr-Commit-Position: refs/heads/master@{#388451}