Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1333)

Issue 1901093002: Reland of "🏄 [heap] Add page evacuation mode for new->old" (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), Michael Hablich, ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Add page evacuation mode for new->old In a full mark-compact GC, instead of copying memory to old space for pages that have more than X% live bytes, we just move the whole page over to old space. X=70 (default value) BUG=chromium:581412 LOG=N TBR=hpayer@chromium.org This reverts commit 8b3337278f4202b058b37dcae35f66a7eef8f5c5. Committed: https://crrev.com/2489738d4ad631580fa139b1bcc84f7f612fcbde Cr-Commit-Position: refs/heads/master@{#35649}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Fix ExternalStringTable handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -77 lines) Patch
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 4 chunks +0 lines, -9 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 15 chunks +120 lines, -46 lines 0 comments Download
M src/heap/spaces.h View 8 chunks +24 lines, -5 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +14 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 2 chunks +16 lines, -1 line 0 comments Download
M test/cctest/heap/test-heap.cc View 1 2 chunks +48 lines, -0 lines 0 comments Download
M test/cctest/heap/utils-inl.h View 1 chunk +23 lines, -12 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901093002/20001
4 years, 8 months ago (2016-04-19 12:57:41 UTC) #4
Michael Achenbach
Stopping this reland. There are also these crashes: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/3844 03:39:30.219 28416 # 03:39:30.219 28416 # ...
4 years, 8 months ago (2016-04-19 13:51:23 UTC) #8
Michael Lippautz
On 2016/04/19 13:51:23, Michael Achenbach wrote: > Stopping this reland. There are also these crashes: ...
4 years, 8 months ago (2016-04-19 15:18:15 UTC) #9
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-04-20 08:27:19 UTC) #10
Michael Lippautz
On 2016/04/19 13:51:23, Michael Achenbach wrote: > Stopping this reland. There are also these crashes: ...
4 years, 8 months ago (2016-04-20 08:50:04 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901093002/40001
4 years, 8 months ago (2016-04-20 08:50:20 UTC) #13
Michael Achenbach
I'll keep an eye on the bot after this lands...
4 years, 8 months ago (2016-04-20 09:03:08 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 09:23:09 UTC) #16
Michael Lippautz
On 2016/04/20 09:03:08, Michael Achenbach wrote: > I'll keep an eye on the bot after ...
4 years, 8 months ago (2016-04-20 09:27:03 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901093002/40001
4 years, 8 months ago (2016-04-20 09:27:16 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-20 09:29:43 UTC) #21
nodir1
4 years, 8 months ago (2016-04-22 18:43:52 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2489738d4ad631580fa139b1bcc84f7f612fcbde
Cr-Commit-Position: refs/heads/master@{#35649}

Powered by Google App Engine
This is Rietveld 408576698