Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1901063002: [wasm] Copy the tagged-to-int32/float64 and int32/float64-to-tagged code to the wasm compiler. (Closed)

Created:
4 years, 8 months ago by ahaas
Modified:
4 years, 8 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Copy the tagged-to-int32/float64 and int32/float64-to-tagged code to the wasm compiler. Thereby we can get rid of the use of Typer and ChangeLowering in the wasm compiler. BUG=v8:4914 R=titzer@chromium.org, bmeurer@chromium.org LOG=N Committed: https://crrev.com/0c6ec35ba40ce5e14afd2b739569c59192277dfa Cr-Commit-Position: refs/heads/master@{#35655}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -58 lines) Patch
M src/compiler/wasm-compiler.h View 4 chunks +18 lines, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 8 chunks +302 lines, -56 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ahaas
4 years, 8 months ago (2016-04-19 08:34:30 UTC) #1
titzer
https://codereview.chromium.org/1901063002/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/1901063002/diff/1/src/compiler/wasm-compiler.cc#newcode2134 src/compiler/wasm-compiler.cc:2134: // Type* const value_type = NodeProperties::GetType(value); I don't think ...
4 years, 8 months ago (2016-04-19 12:08:46 UTC) #2
ahaas
https://codereview.chromium.org/1901063002/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/1901063002/diff/1/src/compiler/wasm-compiler.cc#newcode2134 src/compiler/wasm-compiler.cc:2134: // Type* const value_type = NodeProperties::GetType(value); On 2016/04/19 at ...
4 years, 8 months ago (2016-04-19 18:00:05 UTC) #3
titzer
lgtm
4 years, 8 months ago (2016-04-20 09:05:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1901063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1901063002/20001
4 years, 8 months ago (2016-04-20 11:40:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 11:43:51 UTC) #8
nodir1
4 years, 8 months ago (2016-04-22 18:44:05 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c6ec35ba40ce5e14afd2b739569c59192277dfa
Cr-Commit-Position: refs/heads/master@{#35655}

Powered by Google App Engine
This is Rietveld 408576698