fix issue of Heap Use-After-Free in CXFA_LayoutItem::AddChild

fix issue of Heap Use-After-Free in CXFA_LayoutItem::AddChild

BUG=chromium:590711
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/b02012d565e2596c79c41c6fbf7f2ed88c4bbc51

[Jim Wang, 2016-04-19 07:01:37]

jinming_wang@foxitsoftware.com changed reviewers:
+ ochang@chromium.org, thestig@chromium.org, tsepez@chromium.org

[Jim Wang, 2016-04-19 07:01:37]

Hello all, please help to review this CL, thanks.

[Jim Wang, 2016-04-19 07:02:41]

Description was changed from

==========
fix issue of Heap Use-After-Free in CXFA_LayoutItem::AddChild

BUG=chromium:590711
==========

to

==========
fix issue of Heap Use-After-Free in CXFA_LayoutItem::AddChild

BUG=chromium:590711
==========

[Jim Wang, 2016-04-19 07:02:41]

jinming_wang@foxitsoftware.com changed reviewers:
+ hong_zhang@foxitsoftware.com, kai_jing@foxitsoftware.com,
zhiwei_lin@foxitsoftware.com

[Tom Sepez, 2016-04-19 17:48:21]

Very nice. LGTM.

If you wanted to wordsmith the CL description, it might read:

"Fix heap use-after-free in CXFA_LayoutItem::AddChild()"

And the body might say:

Child must be removed from its parent before deleting it.

or some such.  Thanks!

[Jim Wang, 2016-04-20 00:37:36]

Description was changed from

==========
fix issue of Heap Use-After-Free in CXFA_LayoutItem::AddChild

BUG=chromium:590711
==========

to

==========
fix issue of Heap Use-After-Free in CXFA_LayoutItem::AddChild

BUG=chromium:590711
R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/b02012d565e2596c79c41c6fbf7f2ed88c4b...
==========

[Jim Wang, 2016-04-20 00:37:40]

Committed patchset #1 (id:1) manually as
b02012d565e2596c79c41c6fbf7f2ed88c4bbc51 (presubmit successful).

[Jim Wang, 2016-04-20 00:42:12]

On 2016/04/19 17:48:21, Tom Sepez wrote:
> Very nice. LGTM.
> 
> If you wanted to wordsmith the CL description, it might read:
> 
> "Fix heap use-after-free in CXFA_LayoutItem::AddChild()"
> 
> And the body might say:
> 
> Child must be removed from its parent before deleting it.
> 
> or some such.  Thanks!

Thanks for you advice!

[dsinclair, 2016-04-20 12:55:17]

On 2016/04/20 00:42:12, Jim Wang wrote:
> On 2016/04/19 17:48:21, Tom Sepez wrote:
> > Very nice. LGTM.
> > 
> > If you wanted to wordsmith the CL description, it might read:
> > 
> > "Fix heap use-after-free in CXFA_LayoutItem::AddChild()"
> > 
> > And the body might say:
> > 
> > Child must be removed from its parent before deleting it.
> > 
> > or some such.  Thanks!
> 
> Thanks for you advice!


For future note, you can click the 'Commit' checkbox on the code review tool to
have the code submitted now, no need to land manually. This will run it through
the try bots to make sure nothing breaks.  You can also do 'git cl try' from the
commandline to test the change on the various bots ahead of time.