Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: cc/output/renderer_pixeltest.cc

Issue 1900953004: Switch DrawImage to sk_sp<> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Florin's nit Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/renderer_pixeltest.cc
diff --git a/cc/output/renderer_pixeltest.cc b/cc/output/renderer_pixeltest.cc
index e07513b26872a679642107efcd6928952c88dbed..5451829e117a5b6244b4a5c39ce1376459ada90c 100644
--- a/cc/output/renderer_pixeltest.cc
+++ b/cc/output/renderer_pixeltest.cc
@@ -19,6 +19,7 @@
#include "third_party/skia/include/core/SkColorPriv.h"
#include "third_party/skia/include/core/SkImageFilter.h"
#include "third_party/skia/include/core/SkMatrix.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
#include "third_party/skia/include/core/SkSurface.h"
#include "third_party/skia/include/effects/SkColorFilterImageFilter.h"
#include "third_party/skia/include/effects/SkColorMatrixFilter.h"
@@ -2569,13 +2570,13 @@ TYPED_TEST(SoftwareRendererPixelTest, PictureDrawQuadDisableImageFiltering) {
canvas->drawPoint(0, 1, SK_ColorBLUE);
canvas->drawPoint(1, 0, SK_ColorBLUE);
canvas->drawPoint(1, 1, SK_ColorGREEN);
- skia::RefPtr<SkImage> image = skia::AdoptRef(surface->newImageSnapshot());
std::unique_ptr<FakeRecordingSource> recording =
FakeRecordingSource::CreateFilledRecordingSource(viewport.size());
SkPaint paint;
paint.setFilterQuality(kLow_SkFilterQuality);
- recording->add_draw_image_with_paint(image.get(), gfx::Point(), paint);
+ recording->add_draw_image_with_paint(surface->makeImageSnapshot(),
+ gfx::Point(), paint);
recording->Rerecord();
scoped_refptr<FakeRasterSource> raster_source =
FakeRasterSource::CreateFromRecordingSource(recording.get(), false);
@@ -2618,13 +2619,13 @@ TYPED_TEST(SoftwareRendererPixelTest, PictureDrawQuadNearestNeighbor) {
canvas->drawPoint(0, 1, SK_ColorBLUE);
canvas->drawPoint(1, 0, SK_ColorBLUE);
canvas->drawPoint(1, 1, SK_ColorGREEN);
- skia::RefPtr<SkImage> image = skia::AdoptRef(surface->newImageSnapshot());
std::unique_ptr<FakeRecordingSource> recording =
FakeRecordingSource::CreateFilledRecordingSource(viewport.size());
SkPaint paint;
paint.setFilterQuality(kLow_SkFilterQuality);
- recording->add_draw_image_with_paint(image.get(), gfx::Point(), paint);
+ recording->add_draw_image_with_paint(surface->makeImageSnapshot(),
+ gfx::Point(), paint);
recording->Rerecord();
scoped_refptr<FakeRasterSource> raster_source =
FakeRasterSource::CreateFromRecordingSource(recording.get(), false);

Powered by Google App Engine
This is Rietveld 408576698