Issue 1900923003: Fix CrossProcessPopupInheritsSandboxFlagsWithNoOpener on M50 official builds.

Issue 1900923003: Fix CrossProcessPopupInheritsSandboxFlagsWithNoOpener on M50 official builds. (Closed)

Created:
4 years, 8 months ago by alexmos

Modified:
4 years, 8 months ago

Reviewers:
Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

Fix CrossProcessPopupInheritsSandboxFlagsWithNoOpener on M50 official builds. The test depended on a behavior change in NavigateFrameToURL (wait for full load, rather than commit), which was introduced in https://codereview.chromium.org/1816733002/ and isn't in M50. Use WaitForLoadStop to wait for the full page to load instead. BUG=604559 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation R=creis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ff228a374881cbd34de7a4c15c12681679de2fe0

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	content/browser/frame_host/render_frame_host_manager_browsertest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (4 generated)

alexmos

4 years, 8 months ago (2016-04-21 23:04:53 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ff228a374881cbd34de7a4c15c12681679de2fe0 (presubmit successful).