Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 1900913003: Move build/ to build_gyp/. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Move build/ to build_gyp/. This CL moves the build/ files to build_gyp/ in anticipation of pulling in Chromiums build/ directory. The gyp_pdfium files have been duplicated into both places. Once the bots are updated we'll remove the build/ versions. BUG=pdfium:106 Committed: https://pdfium.googlesource.com/pdfium/+/c37b04e80aafc8437d458ced2366f825749ae2d7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -689 lines) Patch
M .gitignore View 1 chunk +1 line, -3 lines 0 comments Download
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M README.md View 4 chunks +6 lines, -6 lines 0 comments Download
D build/all.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M build/gyp_pdfium View 2 chunks +3 lines, -3 lines 1 comment Download
D build/mac_find_sdk.py View 1 chunk +0 lines, -93 lines 0 comments Download
D build/set_clang_warning_flags.gypi View 1 chunk +0 lines, -58 lines 0 comments Download
D build/standalone.gypi View 1 chunk +0 lines, -507 lines 0 comments Download
A + build_gyp/all.gyp View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build_gyp/gyp_pdfium View 2 chunks +3 lines, -3 lines 0 comments Download
A + build_gyp/gyp_pdfium.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build_gyp/mac_find_sdk.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build_gyp/set_clang_warning_flags.gypi View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build_gyp/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-19 14:06:16 UTC) #2
Tom Sepez
LGTM. Good luck. thanks.
4 years, 8 months ago (2016-04-19 17:39:11 UTC) #3
Lei Zhang
https://codereview.chromium.org/1900913003/diff/1/build/gyp_pdfium File build/gyp_pdfium (right): https://codereview.chromium.org/1900913003/diff/1/build/gyp_pdfium#newcode1 build/gyp_pdfium:1: #!/usr/bin/env python Should this file have been deleted in ...
4 years, 8 months ago (2016-04-19 17:41:07 UTC) #4
dsinclair
On 2016/04/19 17:41:07, Lei Zhang wrote: > https://codereview.chromium.org/1900913003/diff/1/build/gyp_pdfium > File build/gyp_pdfium (right): > > https://codereview.chromium.org/1900913003/diff/1/build/gyp_pdfium#newcode1 ...
4 years, 8 months ago (2016-04-19 17:43:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900913003/1
4 years, 8 months ago (2016-04-19 18:03:45 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 18:04:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c37b04e80aafc8437d458ced2366f825749a...

Powered by Google App Engine
This is Rietveld 408576698