Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1900903002: Fix content/shell including internals of content for service worker test. (Closed)

Created:
4 years, 8 months ago by jam
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix content/shell including internals of content for service worker test. BUG=597020 Committed: https://crrev.com/21c9135843f8d28df74b47f5c05486a59a01ae27 Cr-Commit-Position: refs/heads/master@{#388254}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fixes #

Total comments: 1

Patch Set 4 : more missing dependencies #

Patch Set 5 : fix ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -29 lines) Patch
M chrome/chrome_gpu.gypi View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/gpu/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/components.gyp View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M components/contextual_search.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/common/mojo/service_registry_impl.h View 2 chunks +3 lines, -11 lines 0 comments Download
M content/common/mojo/service_registry_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/service_registry.h View 2 chunks +12 lines, -0 lines 0 comments Download
M content/shell/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M content/shell/browser/shell_mojo_test_utils_android.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 1 2 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jam
https://codereview.chromium.org/1900903002/diff/40001/media/mojo/interfaces/mojo_bindings.gyp File media/mojo/interfaces/mojo_bindings.gyp (right): https://codereview.chromium.org/1900903002/diff/40001/media/mojo/interfaces/mojo_bindings.gyp#newcode32 media/mojo/interfaces/mojo_bindings.gyp:32: 'variables': { this isn't strictly related to this bug, ...
4 years, 8 months ago (2016-04-19 00:04:50 UTC) #2
brettw
lgtm
4 years, 8 months ago (2016-04-19 18:17:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900903002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900903002/80001
4 years, 8 months ago (2016-04-19 18:22:47 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-19 18:28:28 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:09 UTC) #8
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/21c9135843f8d28df74b47f5c05486a59a01ae27
Cr-Commit-Position: refs/heads/master@{#388254}

Powered by Google App Engine
This is Rietveld 408576698