Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 19009003: Suppress array bounds check for nacl build. (Closed)

Created:
7 years, 5 months ago by Michael Achenbach
Modified:
7 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Brad Chen (chromium)
Visibility:
Public.

Description

Suppress array bounds check for nacl build. The NaCl and the ARM builder started failing to compile at revision 15593 with spurious array bounds warnings. The ARM builder will be fixed by updating the cross-compiler version. Since the nacl compiler comes with the nacl toolchain, the warning will be suppressed for that builder. See also: http://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=array%20subscript%20is%20above%20array%20bounds R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Makefile.nacl View 1 chunk +2 lines, -1 line 0 comments Download
M build/toolchain.gypi View 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years, 5 months ago (2013-07-10 16:13:16 UTC) #1
Jakob Kummerow
lgtm
7 years, 5 months ago (2013-07-10 16:18:05 UTC) #2
Michael Achenbach
7 years, 5 months ago (2013-07-10 16:21:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15608 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698