Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1900873006: Add missing IDL parser support for 'stringifier readonly attribute'. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
haraken, Jens Widell, Nico
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing IDL parser support for 'stringifier readonly attribute'. R= BUG=306606 Committed: https://crrev.com/ffb5cc6ac6951e3b311b6d275da2d333f4e44243 Cr-Commit-Position: refs/heads/master@{#388484}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M third_party/WebKit/Source/bindings/tests/idls/core/TestInterface3.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp View 4 chunks +29 lines, -0 lines 0 comments Download
M tools/idl_parser/idl_parser.py View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 22 (7 generated)
sof
please take a look.
4 years, 8 months ago (2016-04-20 07:51:49 UTC) #2
haraken
LGTM
4 years, 8 months ago (2016-04-20 07:52:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900873006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900873006/1
4 years, 8 months ago (2016-04-20 08:06:25 UTC) #5
Jens Widell
LGTM
4 years, 8 months ago (2016-04-20 08:09:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/170733)
4 years, 8 months ago (2016-04-20 08:14:23 UTC) #8
sof
Who owns idl_parser/ more? Adding thakis@ for tools/idl_parser/ approval.
4 years, 8 months ago (2016-04-20 08:19:59 UTC) #10
haraken
c.f., adding tools/idl_parser/OWNERS: https://codereview.chromium.org/1897293004/
4 years, 8 months ago (2016-04-20 08:27:22 UTC) #11
Jens Widell
https://codereview.chromium.org/1900873006/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/1900873006/diff/1/tools/idl_parser/idl_parser.py#newcode563 tools/idl_parser/idl_parser.py:563: elif p[1] != ';': BTW, this ought to be ...
4 years, 8 months ago (2016-04-20 08:32:07 UTC) #12
sof
https://codereview.chromium.org/1900873006/diff/1/tools/idl_parser/idl_parser.py File tools/idl_parser/idl_parser.py (right): https://codereview.chromium.org/1900873006/diff/1/tools/idl_parser/idl_parser.py#newcode563 tools/idl_parser/idl_parser.py:563: elif p[1] != ';': On 2016/04/20 08:32:07, Jens Widell ...
4 years, 8 months ago (2016-04-20 08:49:27 UTC) #13
sof
On 2016/04/20 08:49:27, sof wrote: > https://codereview.chromium.org/1900873006/diff/1/tools/idl_parser/idl_parser.py > File tools/idl_parser/idl_parser.py (right): > > https://codereview.chromium.org/1900873006/diff/1/tools/idl_parser/idl_parser.py#newcode563 > ...
4 years, 8 months ago (2016-04-20 11:42:51 UTC) #14
haraken
On 2016/04/20 11:42:51, sof wrote: > On 2016/04/20 08:49:27, sof wrote: > > > https://codereview.chromium.org/1900873006/diff/1/tools/idl_parser/idl_parser.py ...
4 years, 8 months ago (2016-04-20 11:45:35 UTC) #15
sof
On 2016/04/20 11:45:35, haraken wrote: > On 2016/04/20 11:42:51, sof wrote: > > On 2016/04/20 ...
4 years, 8 months ago (2016-04-20 11:47:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900873006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900873006/20001
4 years, 8 months ago (2016-04-20 11:47:45 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 13:18:51 UTC) #20
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:23:03 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ffb5cc6ac6951e3b311b6d275da2d333f4e44243
Cr-Commit-Position: refs/heads/master@{#388484}

Powered by Google App Engine
This is Rietveld 408576698