Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1900873004: [Mac][Material Design] Add space between icon and text in location bar. (Closed)

Created:
4 years, 8 months ago by shrike
Modified:
4 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac][Material Design] Add space between icon and text in location bar. The spec calls for one additional pt of space between the icon and the text. R=avi@chromium.org BUG=596684 Committed: https://crrev.com/03a74b53c60029b17689f292b828c72df020406a Cr-Commit-Position: refs/heads/master@{#388550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shrike
PTAL
4 years, 8 months ago (2016-04-19 21:37:29 UTC) #1
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-20 04:00:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900873004/1
4 years, 8 months ago (2016-04-20 17:46:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 19:33:32 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:25:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03a74b53c60029b17689f292b828c72df020406a
Cr-Commit-Position: refs/heads/master@{#388550}

Powered by Google App Engine
This is Rietveld 408576698