Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1900873002: Revert of [Android] Get package_info by using apk_under_test package. (Closed)

Created:
4 years, 8 months ago by mikecase (-- gone --)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Get package_info by using apk_under_test package. (patchset #1 id:1 of https://codereview.chromium.org/1893693002/ ) Reason for revert: Breaks the MogoTests due to this error. AttributeError: 'NoneType' object has no attribute 'GetPackageName' Original issue's description: > [Android] Get package_info by using apk_under_test package. > > Currently, the package_info used by the test apk is looked up by > by looking at the test_apk package in the list of package_infos. > Instead, we can just look at the package entries in the list > of package_infos and compare it to the package of the apk_under_test. > > This makes things much nicer, when for instance you have multiple > test apks targeting the same package. > > BUG= > > Committed: https://crrev.com/f6c372aea4a4c79598b9414a9049b7ac5f659f2e > Cr-Commit-Position: refs/heads/master@{#387943} TBR=agrieve@chromium.org,rnephew@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/56023c5c64b3c0af9c701b74e33e1f1e00f884eb Cr-Commit-Position: refs/heads/master@{#387996}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M build/android/pylib/constants/__init__.py View 1 chunk +28 lines, -11 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
mikecase (-- gone --)
Created Revert of [Android] Get package_info by using apk_under_test package.
4 years, 8 months ago (2016-04-18 20:10:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900873002/1
4 years, 8 months ago (2016-04-18 20:11:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:12:27 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:13:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56023c5c64b3c0af9c701b74e33e1f1e00f884eb
Cr-Commit-Position: refs/heads/master@{#387996}

Powered by Google App Engine
This is Rietveld 408576698