Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: runtime/vm/ast.h

Issue 1900863004: VM: Remove _leftShiftWithMask32. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/ast.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/ast.h
diff --git a/runtime/vm/ast.h b/runtime/vm/ast.h
index 4ca237268e5a1280eeeda36c8851a30323da699e..13184af4143c856db692ed5db510c96732da660c 100644
--- a/runtime/vm/ast.h
+++ b/runtime/vm/ast.h
@@ -24,7 +24,6 @@ namespace dart {
V(Type) \
V(Assignable) \
V(BinaryOp) \
- V(BinaryOpWithMask32) \
V(Comparison) \
V(UnaryOp) \
V(ConditionalExpr) \
@@ -769,36 +768,6 @@ class BinaryOpNode : public AstNode {
};
-class BinaryOpWithMask32Node : public BinaryOpNode {
- public:
- BinaryOpWithMask32Node(TokenPosition token_pos,
- Token::Kind kind_value,
- AstNode* left,
- AstNode* right,
- int64_t mask32)
- : BinaryOpNode(token_pos, kind_value, left, right), mask32_(mask32) {
- ASSERT(mask32 >= 0 && Utils::IsUint(32, mask32));
- ASSERT((kind_value != Token::kAND) && (kind_value != Token::kOR));
- }
-
- // The optional 32-bit mask must be a an unsigned 32-bit value.
- virtual bool has_mask32() const { return true; }
- virtual int64_t mask32() const {
- ASSERT(has_mask32());
- return mask32_;
- }
-
- const char* TokenName() const;
- DECLARE_COMMON_NODE_FUNCTIONS(BinaryOpWithMask32Node);
-
- private:
- // Optional unsigned 32 bit mask applied on result. No mask: -1.
- const int64_t mask32_;
-
- DISALLOW_IMPLICIT_CONSTRUCTORS(BinaryOpWithMask32Node);
-};
-
-
class UnaryOpNode : public AstNode {
public:
// Returns optimized version, e.g., for ('-' '1') ('-1') literal is returned.
« no previous file with comments | « runtime/vm/aot_optimizer.cc ('k') | runtime/vm/ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698